Move index values cache to bucket level to prevent race condition #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: yeya24 <[email protected]>
|
The benchmark results are below and I did it twice. Comparing this pr with thanos-io#3705. The performance is similar overall, only a little bit improvement. Ideally, this can be improved more by using more fine-grained locks, but I haven't benchmarked it. |
yeya24
commented
Jan 7, 2021
| // Only update the cache if the block cache entry is not set. | ||
| if v != zeroIndexSymbol && r.block.valueSymbols[k] == zeroIndexSymbol { | ||
| r.block.valueSymbols[k] = v | ||
| } |
There was a problem hiding this comment.
This might be a problem. Not sure which way is better. Overwrite the entry every time?
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: yeya24 [email protected]
The
indexHeaderis shared so we need to use locks. However, the upper levelbucketIndexReaderis one-per request so we don't need to add locks there. The idea is to move the values cache to the bucket level.Changes
Verification