Separate yext/studio into yext/studio-ui #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Safelist into studio-plugin
oshi97
changed the title
oshi97
changed the title
alextaing
reviewed
Sep 6, 2023
alextaing
reviewed
Sep 7, 2023
alextaing
reviewed
Sep 7, 2023
alextaing
reviewed
Sep 7, 2023
alextaing
reviewed
Sep 7, 2023
|
lgtm 🔥 but @nmanu1, do you want to take a gander? |
nmanu1
reviewed
Sep 8, 2023
nmanu1
reviewed
Sep 15, 2023
This PR removes top-level fragments from the component tree of each layout in the layout slice so they won't be displayed in the UI when adding a layout to a new page. HMR is also updated to re-sync layouts in the store when a layout file is changed or a full sync is performed. J=SLAP-2937 TEST=manual In the test-site, saw that if `LocationLayout` had a top-level fragment, it was not present in the component tree in the `layouts` record. Also, checked that updating `LocationLayout` while running the test-site would correctly update it's component tree in the store.
|
Things look good to me! 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR separates the react and zustand code into yext/studio-ui.
A future PR will replace the typescript compiler with a bundler, which will reduce round trips done by the vite dev server
and also allow us to minify the code.
generateTailwindSafelist had to be moved into studio-plugin, otherwise postcss would complain about things like
windownot existing. This was due to postcss importing all of studio-ui when it tries to import generateTailwindSafelist, and postcss running on node while studio-ui expecting to be run in the browser. Previously, it would directlyimport the ts file, and rely on whatever transpilation postcss/tailwind are doing.
J=SLAP-2919
TEST=manual
dev flow still works - I can make an edit in studio-ui with the dev watch running and the test-site will receive updates
it's a full page reload every time now though