Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 #423

Merged
merged 45 commits into from
Feb 20, 2024
Merged
Show file tree
Hide file tree
Changes from 34 commits
Commits
Show all changes
45 commits
Select commit Hold shift + click to select a range
d425b03
upgrade to react18 file updates
jesuyedavid Jan 31, 2024
1ef4bf6
Update snapshots
github-actions[bot] Feb 8, 2024
b9da340
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Feb 8, 2024
0a7b3a5
update mapbox gl version
jesuyedavid Feb 8, 2024
f730558
Merge branch 'react18upgrade' of github.com:yext/search-ui-react into…
jesuyedavid Feb 8, 2024
cda71b5
initialize eslint config
jesuyedavid Feb 8, 2024
8e02c1d
runlinting and wcag build failures
jesuyedavid Feb 8, 2024
46898ae
pr fixes and test site updates
jesuyedavid Feb 9, 2024
101c0fb
misc pr fixes
jesuyedavid Feb 12, 2024
bb74e66
use react-collapsed types for testing
jesuyedavid Feb 12, 2024
cff19d1
pr fixes
jesuyedavid Feb 13, 2024
c06ffa8
pr fixes
jesuyedavid Feb 14, 2024
cbb6606
pr fixes
jesuyedavid Feb 14, 2024
377a578
package json cleanup
jesuyedavid Feb 14, 2024
390534e
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Feb 14, 2024
c296f47
add new react17 github workflow
jesuyedavid Feb 14, 2024
194e516
added npm install step to new workflow
jesuyedavid Feb 14, 2024
5cac87b
add swc libs to github workflow step
jesuyedavid Feb 14, 2024
6d002a1
add swc libs to github workflow step2
jesuyedavid Feb 14, 2024
9b77fb6
Clean up tests
nmanu1 Feb 14, 2024
58e4a84
run npm install after react17 deps
jesuyedavid Feb 14, 2024
6bb06d4
move swc post install libs into runtest yaml file
jesuyedavid Feb 14, 2024
9680ae9
await async test calls
nmanu1 Feb 14, 2024
a3e242f
ignore link click errors in tests
nmanu1 Feb 14, 2024
339ddd7
use id fix and remove render hooks console error
jesuyedavid Feb 14, 2024
f6663da
Automated update to THIRD-PARTY-NOTICES from github action's 3rd part…
github-actions[bot] Feb 14, 2024
76782b9
npm pack search ui react
jesuyedavid Feb 14, 2024
b00d9fd
npm pack search ui react2
jesuyedavid Feb 14, 2024
9952690
Clean up
nmanu1 Feb 15, 2024
f77e463
formatting tweaks
nmanu1 Feb 15, 2024
b0cd849
add react strict mode
jesuyedavid Feb 15, 2024
90ecea6
Merge branch 'react18upgrade' of github.com:yext/search-ui-react into…
jesuyedavid Feb 15, 2024
97c92c4
Merge remote-tracking branch 'origin/develop' into react18upgrade
jesuyedavid Feb 15, 2024
c6dcbe6
reverted version and updated filtersearch
jesuyedavid Feb 15, 2024
23120fe
updated package lock json
jesuyedavid Feb 15, 2024
76fcf6a
update packagelock for root project
jesuyedavid Feb 15, 2024
c4a2e8d
update mapbox map to latest react
jesuyedavid Feb 16, 2024
0bf719e
fix live api key
jesuyedavid Feb 16, 2024
51b9e82
react18 and less reactdom
jesuyedavid Feb 16, 2024
5456ded
Fix tests
nmanu1 Feb 16, 2024
2c78f34
Fix storybook on react 18
nmanu1 Feb 16, 2024
58d7384
Update snapshots
github-actions[bot] Feb 16, 2024
e22f1c5
Switch to providing renderPin prop
nmanu1 Feb 16, 2024
4ea7aa3
Update snapshots
github-actions[bot] Feb 16, 2024
409af48
fix tests
nmanu1 Feb 17, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
42 changes: 41 additions & 1 deletion .github/workflows/run-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,36 @@ name: Run Tests
on: [push, pull_request]

jobs:
call_run_tests-react-18:
uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
with:
node_matrix: '["16.x", "18.x"]'
secrets:
MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }}

call_run_tests-react-17:
uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
with:
# We have to install these swc libraries manually because
# the post install script doesn't seem to run properly
# after we install specific versions of packages.
# More info at https://github.com/swc-project/swc/issues/5616#issuecomment-1651214641
build_script: |
npm i \
react@^17.0.2 \
react-dom@^17.0.2 \
@testing-library/react@^12.1.3 \
@testing-library/react-hooks@^8.0.0
npm install --save-optional \
"@swc/core-linux-arm-gnueabihf" \
"@swc/core-linux-arm64-gnu" \
"@swc/core-linux-arm64-musl" \
"@swc/core-linux-x64-gnu" \
"@swc/core-linux-x64-musl" \
"@swc/core-win32-arm64-msvc" \
"@swc/core-win32-ia32-msvc" \
"@swc/core-win32-x64-msvc"
npm run build
node_matrix: '["16.x", "18.x"]'
secrets:
MAPBOX_API_KEY: ${{ secrets.MAPBOX_API_KEY }}
Expand All @@ -17,7 +44,20 @@ jobs:
uses: yext/slapshot-reusable-workflows/.github/workflows/run_tests.yml@v1
with:
build_script: |
npm i -D [email protected] [email protected]
npm i \
react@^16.14 \
react-dom@^16.14 \
@testing-library/react@^12.1.3 \
@testing-library/react-hooks@^8.0.0
npm install --save-optional \
"@swc/core-linux-arm-gnueabihf" \
"@swc/core-linux-arm64-gnu" \
"@swc/core-linux-arm64-musl" \
"@swc/core-linux-x64-gnu" \
"@swc/core-linux-x64-musl" \
"@swc/core-win32-arm64-msvc" \
"@swc/core-win32-ia32-msvc" \
"@swc/core-win32-x64-msvc"
npm run build
node_matrix: '["16.x", "18.x"]'
secrets:
Expand Down
Binary file modified .storybook/snapshots/__snapshots__/mapboxmap--multiple-pins.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
69 changes: 19 additions & 50 deletions THIRD-PARTY-NOTICES
Original file line number Diff line number Diff line change
Expand Up @@ -328,36 +328,6 @@ CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following NPM packages may be included in this product:

- @reach/[email protected]
- @reach/[email protected]

These packages each contain the following license and notice below:

The MIT License (MIT)

Copyright (c) 2018-2022, React Training LLC

Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following NPM package may be included in this product:

- @react-aria/[email protected]
Expand Down Expand Up @@ -2777,7 +2747,7 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI

The following NPM package may be included in this product:

- [email protected].6
- [email protected].7

This package contains the following license and notice below:

Expand Down Expand Up @@ -3195,7 +3165,7 @@ OTHER DEALINGS IN THE SOFTWARE.

The following NPM package may be included in this product:

- [email protected].30
- [email protected].35

This package contains the following license and notice below:

Expand Down Expand Up @@ -3357,40 +3327,39 @@ THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLI

The following NPM package may be included in this product:

- react-collapsed@3.6.0
- react-collapsed@4.1.2

This package contains the following license and notice below:

MIT License
The MIT License (MIT)

Copyright (c) 2019-2020 Rogin Farrer
Copyright (c) 2019-2023, Rogin Farrer

Permission is hereby granted, free of charge, to any person obtaining a copy
of this software and associated documentation files (the "Software"), to deal
in the Software without restriction, including without limitation the rights
to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
copies of the Software, and to permit persons to whom the Software is
furnished to do so, subject to the following conditions:
Permission is hereby granted, free of charge, to any person obtaining a copy of
this software and associated documentation files (the "Software"), to deal in
the Software without restriction, including without limitation the rights to
use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of
the Software, and to permit persons to whom the Software is furnished to do so,
subject to the following conditions:

The above copyright notice and this permission notice shall be included in all
copies or substantial portions of the Software.

THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
SOFTWARE.
IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER
IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN
CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

-----------

The following NPM packages may be included in this product:

- react-dom@17.0.2
- react-dom@18.2.0
- [email protected]
- react@17.0.2
- scheduler@0.20.2
- react@18.2.0
- scheduler@0.23.0
- [email protected]

These packages each contain the following license and notice below:
Expand Down
Loading
Loading