Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(dev/plugin): support secrets #433

Merged
merged 5 commits into from
Nov 13, 2023
Merged

feat(dev/plugin): support secrets #433

merged 5 commits into from
Nov 13, 2023

Conversation

mkilpatrick
Copy link
Collaborator

@mkilpatrick mkilpatrick commented Nov 8, 2023

This adds support for truly secret environment variables. Before this change we only supported public environment variables that were prefixed with YEXT_PUBLIC.

@mkilpatrick mkilpatrick requested a review from a team as a code owner November 8, 2023 23:01
asanehisa
asanehisa previously approved these changes Nov 9, 2023
Copy link
Contributor

@asanehisa asanehisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

packages/pages/src/util/processEnvVariables.ts Outdated Show resolved Hide resolved
jwartofsky-yext
jwartofsky-yext previously approved these changes Nov 9, 2023
Copy link
Contributor

@jwartofsky-yext jwartofsky-yext left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mkilpatrick mkilpatrick dismissed stale reviews from jwartofsky-yext and asanehisa via 1a76417 November 9, 2023 21:48
asanehisa
asanehisa previously approved these changes Nov 9, 2023
@mkilpatrick
Copy link
Collaborator Author

I've opened an issue with VIte re: the Ubuntu failures. Looks like it has to do with loadEnv and an empty string prefix.

@mkilpatrick mkilpatrick merged commit 2df1478 into main Nov 13, 2023
13 checks passed
@mkilpatrick mkilpatrick deleted the secrets branch November 13, 2023 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants