fix(dev): include document support for static page getPath
functions.
#421
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #415.
In the past, if users tried to access
document
fields in a static pagegetPath
function, it would show up as "undefined" in the page URL. This PR addresses this by giving static pages access to thedocument
object.A couple changes were made to accommodate this functionality. We want to pass in a document in order correctly compute a
getPath
function. This means that when we iterate through templates to find the corresponding template document to our URL, (seefindMatchingStaticTemplate
), we need to retrieve the documents which is an asynchronous action. Therefore, thecriterion
function infindTemplateModuleInternal
was changed to accept async functions.For clarity,
urlToFeature
was also refactored. It was also found thatdefaultLocale
was not being used inserverRenderRoute
. Before, we hard-codeden
to be the default Locale inurlToFeature
. But in this refactor, we usedefaultLocale
instead.J=SUMO-5417
TEST=manual