feat(plugin): add ts-morph for client templates #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asanehisa
changed the title
asanehisa
changed the title
mkilpatrick
reviewed
Oct 18, 2023
mkilpatrick
reviewed
Oct 18, 2023
This is _yet another_ change in how we generate features/templates. The story have been to use esbuild, then ts-morph, back to esbuild and now Vite. We use the Vite devServer directly to handle compiling the code so we can import the template module to get the config off of it. This change also replaces Jest with Vitest, which allows the testing of esmodules much more easily. It was also required in order to actually run Vite in some tests. --------- Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
…into SUMO-5293-add-ts-morph
mkilpatrick
reviewed
Oct 20, 2023
asanehisa
commented
Oct 24, 2023
mkilpatrick
reviewed
Oct 24, 2023
mkilpatrick
reviewed
Oct 24, 2023
mkilpatrick
reviewed
Oct 24, 2023
packages/pages/tests/fixtures/sourceFileTemplates/clientState.tsx
Outdated
Show resolved
Hide resolved
mkilpatrick
approved these changes
Oct 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.