update package-lock to respect overrides #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshi97
force-pushed
the
dev/update-overrides
branch
2 times, most recently
from
a9814b2 to
1fa6274
Compare
|
Since release/v1.14 has been cut, should we merge this there? Otherwise, LGTM |
Ah I was thinking I didn't want this to go into the release branch, but I think you're right! |
oshi97
force-pushed
the
dev/update-overrides
branch
from
e9d4953 to
32a0b1f
Compare
oshi97
force-pushed
the
dev/update-overrides
branch
from
32a0b1f to
d8a3f1c
Compare
cea2aj
approved these changes
Apr 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There were a number of issues with npm overrides not being
respected by the npm install command. Supposedly, these issues
have been fixed in npm 8.7.0.
See npm/cli#4709
This PR deletes and regenerates the package-lock so that overrides are respected.
J=SLAP-2022
TEST=manual
see that the unsafe-eval test page loads properly
rerunning npm install does not undo overrides