Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Legacy Card does not support bigDate #679

Closed
creotutar opened this issue Apr 13, 2020 · 0 comments
Closed

Legacy Card does not support bigDate #679

creotutar opened this issue Apr 13, 2020 · 0 comments
Assignees
@alexisgrow
Labels
next patch The solution to this issue will be included in the next patch

Comments

@creotutar
Copy link
Contributor

creotutar commented Apr 13, 2020 •
edited
Loading

Passing in a bigDate data mapping object in a cardMappings/dataMappings but I do not see the big date manifest on the card. I believe this is because the card is expecting bigDate to be on the top-level, whereas every other card mapping lives on the _config level.

I have confirmed through console logging that the bigDate is being passed through into the _config level.

e.g. in legacy.hbs

    {{#if bigDate.day}}

vs.

    {{#if _config.image.url}}
        {{#if _config.subtitle}}

Example bigDate:

bigDate:
day: 3
month: "April"
time: "12:00 AM"
__proto__: Object

Environment
using dist/answers-umd.js
in dist-v0.13.1
@alexisgrow alexisgrow mentioned this issue Apr 16, 2020
Merged
alexisgrow added a commit that referenced this issue Apr 16, 2020
@alexisgrow
Legacy Card: Fix big date in the hbs (#692)
63a04a8 
Update the legacy card to properly reference big date, fixes this issue: #679.

TEST=manual

Locally, create event vertical page and display big date.
@alexisgrow alexisgrow self-assigned this Apr 16, 2020
@rosiegrant rosiegrant added the next patch The solution to this issue will be included in the next patch label Apr 17, 2020
tmeyer2115 pushed a commit that referenced this issue Apr 24, 2020
@alexisgrow @tmeyer2115
Legacy Card: Fix big date in the hbs (#692)
39d99be 
Update the legacy card to properly reference big date, fixes this issue: #679.

TEST=manual

Locally, create event vertical page and display big date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@alexisgrow alexisgrow

Labels
next patch The solution to this issue will be included in the next patch
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@rosiegrant @creotutar @alexisgrow