remove send_future from ComponentLink #799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we should keep the example here too. It's not necessary to use yewtil to use futures |
|
Understood. I'll reinstate the example and provide an implementation of There is the question of #776 though. I think in the meantime, I'll implement it in yewtil and copy the stdweb-compatible implementation of it to the futures example here later? |
|
Thanks! That's just what I had in mind. RE #776, sounds good! |
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
* remove send_future from ComponentLink * Revert "remove send_future from ComponentLink" This reverts commit c1b1ad4. * remove send_future, reimplement it in the futures example
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #792
This also removes the futures example.
Here is where the futures example is migrating to: yewstack/yewtil#37
And
send_futurenow exists here: https://github.com/yewstack/yewtil/blob/596844663be16162f0bbd2f98d36f41b70096adf/src/future.rs#L7