Allow to extend agent communication from external crates #721
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dunnock
force-pushed
the
extensible-agent
branch
from
ed78498
to
5c7af66
Compare
dunnock
force-pushed
the
extensible-agent
branch
from
5c7af66
to
e21d9fe
Compare
dunnock
commented
Oct 31, 2019
|
Looks good! |
llebout
pushed a commit
to llebout/yew
that referenced
this pull request
Jan 20, 2020
* allow to extend agent communication from external crates * Fixing build on rustc 1.35 * implement Default for AgentScope with public new * toml-rs 0.5.5 fixed compatibility with rustc 1.35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed and reopened #719
This PR will open communication data structures to allow external crates to implement custom Agents for their purposes. For example wasi worker implementation which provides ~2x faster execution for wasm target https://github.com/dunnock/wasi-worker.
After opening structures it will be possible to implement custom trait for Agent with Reach=Public to allow custom initialization, also it will allow to provide custom implementation for Responder trait. It should be enough to have custom Agent implementation to be able to communicate with main yew application. Example https://github.com/dunnock/wasi-worker/blob/master/examples/yewworker/src/main.rs