Add ref attributes to enabling DOM access in Components #715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hgzimmerman
approved these changes
Oct 21, 2019
There was a problem hiding this comment.
Looks good.
I think that in high level documentation, when that comes into existence, should mention that this is a rare case where view is able to change the model's state (via a Rc<RefCell<_>>), despite only having a borrowed reference to the model. Because it isn't immediately obvious that mutation is possible there (and is the mechanism through which this feature is made possible) without explicitly bringing up the concept of interior mutability.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #665
NodeCelltoNodeRefoccupiednode cell into a node reference for use in component lifecycle methods