html!: fix explicit return types in callbacks #564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Problem
The html! macro didn't properly handle explicit return types in
callbacks, considering the '>' in '->' as the end of the HTML tag.
```rust
html! {
<div onblur=|_| -> u32 0 />
// ^ here
}
```
Fixes: yewstack#560
|
Looks great, once bors and travis are configured, we can merge! |
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Aug 7, 2019
564: html!: fix explicit return types in callbacks r=jstarry a=totorigolo ### Problem (see #560) The html! macro didn't properly handle explicit return types in callbacks, considering the '>' in '->' as the end of the HTML tag. ```rust html! { <div onblur=|_| -> u32 0 /> // ^ here } ``` Fixes: #560 Co-authored-by: Thomas Lacroix <[email protected]>
Build succeeded
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem (see #560)
The html! macro didn't properly handle explicit return types in
callbacks, considering the '>' in '->' as the end of the HTML tag.
Fixes: #560