Support building wasm targets without cargo-web using wasm-bindgen #497
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jstarry
force-pushed
the
wasm-bindgen
branch
3 times, most recently
from
ec130e7
to
45ea801
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Jul 1, 2019
497: Support building wasm targets without cargo-web using wasm-bindgen r=jstarry a=jstarry Fixes #496 Details: * Conditionally use `wasm-bindgen-test-runner` if cargo web is not used * Bump `stdweb` version from `0.4.14` to `0.14.6` to get latest wasm-bindgen improvements * Conditionally use dep `wasm-bindgen` if cargo web is not used * Automatically apply `wasm_bindgen_test` feature if building for wasm targets without cargo web I made this change in a way that still allows building with cargo-web. But it's now no longer required if targeting wasm Co-authored-by: Justin Starry <[email protected]>
Build succeeded |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #496
Details:
wasm-bindgen-test-runnerif cargo web is not usedstdwebversion from0.4.14to0.14.6to get latest wasm-bindgen improvementswasm-bindgenif cargo web is not usedwasm_bindgen_testfeature if building for wasm targets without cargo webI made this change in a way that still allows building with cargo-web. But it's now no longer required if targeting wasm