-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issues with tuples in closing tag #2886
Conversation
Can you also add a test that uses a non-self-closing tag? This seems to have had different behaviour in the original bug report, so it would make sense to also test for ::yew::html! { <Generic<(u8, bool)> ></Generic<(u8, bool)>> }; |
Visit the preview URL for this PR (updated for commit 3dae63a): https://yew-rs-api--pr2886-issue-2225-test-azx316a1.web.app (expires Sat, 15 Oct 2022 15:47:06 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
Oh right, that's what the original bug report was about then. I can confirm that only non-self closing tags panic! |
html!
|
||
error: this closing tag has no corresponding opening tag | ||
--> $DIR/generic-component-fail.rs:45:30 | ||
| ^^^^^^^ expected 1 generic argument |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! Removing hand-written parsing and getting better errors!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some further small details now that the end type is actually checked.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me now!
Description
This PR:
Fixes #2225
Checklist