-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Simple NodeRef
passing to <Link>
for yew-router
#2877
Conversation
<Link>
for yew-router
<Link>
for yew-routerNodeRef
passing to <Link>
for yew-router
Visit the preview URL for this PR (updated for commit 45f97ab): https://yew-rs-api--pr2877-link-noderef-7yej881h.web.app (expires Sun, 25 Sep 2022 01:35:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
@@ -24,6 +24,9 @@ where | |||
pub query: Option<Q>, | |||
#[prop_or_default] | |||
pub disabled: bool, | |||
/// [`NodeRef`](yew::html::NodeRef) for the `<a>` element. | |||
#[prop_or_default] | |||
pub a_ref: NodeRef, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pub a_ref: NodeRef, | |
pub anchor_ref: NodeRef, |
I think a_ref
should be given a more descriptive name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I agree, I'll change right now.
Description
Implementation of the proposal to add
NodeRef
access to a<Link>
component.Discussion: #2876
Checklist