Add VNode::from_html_unchecked #2842

ranile · 2022-08-24T19:41:36Z

Description

Add method:

impl VNode {
     fn from_html_unchecked(html: &str) -> Self { ... }
}

Fixes #2841

Checklist

I have reviewed my own code
I have added tests

ranile · 2022-08-24T19:49:38Z

I can't get any tests for this to pass:

#[cfg(all(test, not(target_arch = "wasm32")))]
mod tests {
    use super::*;
    use crate::html;

    #[test]
    fn from_raw_html_works() {
        let vnode = html! {
            <><div>{"c"}</div></>
        };

        eprintln!("{:#?}", vnode);

        let from_raw = VNode::from_raw_html("<div>c</div>");
        eprintln!();
        eprintln!("{:#?}", from_raw);

        assert_eq!(vnode, from_raw);
    }
}

Test Output

running 1 test
test virtual_dom::vnode::tests::from_raw_html_works ... FAILED

failures:

---- virtual_dom::vnode::tests::from_raw_html_works stdout ----
VList {
    children: [
        VTag {
            inner: Other {
                tag: "div",
                children: VList {
                    children: [
                        VText { text: "c" },
                    ],
                    fully_keyed: KnownMissingKeys,
                    key: None,
                },
            },
            listeners: None,
            node_ref: NodeRef { references: None },
            attributes: Static(
                [],
            ),
            key: None,
        },
    ],
    fully_keyed: KnownMissingKeys,
    key: None,
}

VList {
    children: [
        VTag {
            inner: Other {
                tag: "div",
                children: VList {
                    children: [
                        VText { text: "c" },
                    ],
                    fully_keyed: KnownMissingKeys,
                    key: None,
                },
            },
            listeners: None,
            node_ref: NodeRef { references: None },
            attributes: Static(
                [],
            ),
            key: None,
        },
    ],
    fully_keyed: KnownMissingKeys,
    key: None,
}
thread 'virtual_dom::vnode::tests::from_raw_html_works' panicked at 'assertion failed: `(left == right)`
  left: `VList { children: [VTag { inner: Other { tag: "div", children: VList { children: [VText { text: "c" }], fully_keyed: KnownMissingKeys, key: None } }, listeners: None, node_ref: NodeRef { references: None }, attributes: Static([]), key: None }], fully_keyed: KnownMissingKeys, key: None }`,
 right: `VList { children: [VTag { inner: Other { tag: "div", children: VList { children: [VText { text: "c" }], fully_keyed: KnownMissingKeys, key: None } }, listeners: None, node_ref: NodeRef { references: None }, attributes: Static([]), key: None }], fully_keyed: KnownMissingKeys, key: None }`', packages/yew/src/virtual_dom/vnode.rs:288:9
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

I don't understand why exactly this test fails

github-actions · 2022-08-24T19:51:08Z

Benchmark - SSR

Yew Master

Benchmark	Round	Min (ms)	Max (ms)	Mean (ms)	Standard Deviation
Baseline	10	371.549	372.557	371.751	0.292
Hello World	10	707.307	716.183	709.373	2.887
Function Router	10	2344.654	2380.579	2361.433	9.339
Concurrent Task	10	1007.340	1009.305	1008.532	0.636

Pull Request

Benchmark	Round	Min (ms)	Max (ms)	Mean (ms)	Standard Deviation
Baseline	10	393.117	393.747	393.393	0.204
Hello World	10	709.091	722.206	714.874	4.073
Function Router	10	2332.463	2365.355	2349.607	9.417
Concurrent Task	10	1007.499	1009.495	1008.602	0.549

github-actions · 2022-08-24T19:54:05Z

Size Comparison

examples	master (KB)	pull request (KB)	diff (KB)	diff (%)
async_clock	106.139	108.607	+2.469	+2.326%
boids	170.366	172.852	+2.485	+1.459%
communication_child_to_parent	90.027	92.507	+2.479	+2.754%
communication_grandchild_with_grandparent	104.879	107.219	+2.340	+2.231%
communication_grandparent_to_grandchild	100.744	103.092	+2.348	+2.330%
communication_parent_to_child	87.134	89.614	+2.480	+2.847%
contexts	107.358	109.881	+2.522	+2.350%
counter	85.050	87.520	+2.470	+2.904%
counter_functional	85.522	88.000	+2.478	+2.897%
dyn_create_destroy_apps	87.882	90.355	+2.474	+2.815%
file_upload	99.645	102.067	+2.423	+2.431%
function_memory_game	162.865	165.333	+2.468	+1.515%
function_router	347.254	349.764	+2.510	+0.723%
function_todomvc	157.658	160.150	+2.492	+1.581%
futures	221.943	224.211	+2.268	+1.022%
game_of_life	104.550	107.018	+2.468	+2.360%
immutable	180.990	184.614	+3.624	+2.002%
inner_html	81.913	84.126	+2.213	+2.702%
js_callback	110.877	113.428	+2.551	+2.301%
keyed_list	195.523	198.045	+2.521	+1.290%
mount_point	84.658	87.130	+2.472	+2.920%
nested_list	111.624	114.168	+2.544	+2.279%
node_refs	92.534	95.009	+2.475	+2.674%
password_strength	1546.897	1549.191	+2.294	+0.148%
portals	95.945	98.518	+2.572	+2.681%
router	317.068	319.561	+2.492	+0.786%
simple_ssr	151.578	154.110	+2.532	+1.671%
ssr_router	392.338	394.761	+2.423	+0.618%
suspense	108.617	111.172	+2.555	+2.352%
timer	87.913	90.381	+2.468	+2.807%
todomvc	138.961	141.444	+2.483	+1.787%
two_apps	85.714	88.190	+2.477	+2.889%
web_worker_fib	152.032	154.515	+2.482	+1.633%
webgl	84.350	86.846	+2.496	+2.959%

⚠️ The following examples have changed their size significantly:

examples	master (KB)	pull request (KB)	diff (KB)	diff (%)
async_clock	106.139	108.607	+2.469	+2.326%
boids	170.366	172.852	+2.485	+1.459%
communication_child_to_parent	90.027	92.507	+2.479	+2.754%
communication_grandchild_with_grandparent	104.879	107.219	+2.340	+2.231%
communication_grandparent_to_grandchild	100.744	103.092	+2.348	+2.330%
communication_parent_to_child	87.134	89.614	+2.480	+2.847%
contexts	107.358	109.881	+2.522	+2.350%
counter	85.050	87.520	+2.470	+2.904%
counter_functional	85.522	88.000	+2.478	+2.897%
dyn_create_destroy_apps	87.882	90.355	+2.474	+2.815%
file_upload	99.645	102.067	+2.423	+2.431%
function_memory_game	162.865	165.333	+2.468	+1.515%
function_todomvc	157.658	160.150	+2.492	+1.581%
futures	221.943	224.211	+2.268	+1.022%
game_of_life	104.550	107.018	+2.468	+2.360%
immutable	180.990	184.614	+3.624	+2.002%
inner_html	81.913	84.126	+2.213	+2.702%
js_callback	110.877	113.428	+2.551	+2.301%
keyed_list	195.523	198.045	+2.521	+1.290%
mount_point	84.658	87.130	+2.472	+2.920%
nested_list	111.624	114.168	+2.544	+2.279%
node_refs	92.534	95.009	+2.475	+2.674%
portals	95.945	98.518	+2.572	+2.681%
simple_ssr	151.578	154.110	+2.532	+1.671%
suspense	108.617	111.172	+2.555	+2.352%
timer	87.913	90.381	+2.468	+2.807%
todomvc	138.961	141.444	+2.483	+1.787%
two_apps	85.714	88.190	+2.477	+2.889%
web_worker_fib	152.032	154.515	+2.482	+1.633%
webgl	84.350	86.846	+2.496	+2.959%

packages/yew/src/virtual_dom/vnode.rs

packages/yew/Cargo.toml

github-actions · 2022-08-27T21:21:51Z

Visit the preview URL for this PR (updated for commit 4850d52):

https://yew-rs-api--pr2842-html-from-raw-v3ysmy42.web.app

_{(expires Sun, 13 Nov 2022 16:20:14 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

WorldSEnder

I would like to see an explanation for the increase in bundle size for the examples not using inner html. Other than that, I think reusing the vlist/blist implementation could save a bit of duplicated code.

packages/yew/src/dom_bundle/braw.rs

WorldSEnder

Test coverage seems good, and I don't see any more issues with the code.

Figuring out why this increases the bundle size is not blocking imo, even if it would be nice not to pay the additional 2kB.

ranile · 2022-11-08T16:24:42Z

I couldn't figure out anything regarding size increase. If I had to guess, maybe it's because yew now enables more web-sys features? Not quite sure. 2KB isn't much, especially with how .wasm files compress.

I'm going to go ahead and merge this

ranile added the A-yew Area: The main yew crate label Aug 24, 2022

ranile added this to the v0.20 milestone Aug 24, 2022

github-actions bot previously approved these changes Aug 24, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via 55a2558 August 24, 2022 19:57

github-actions bot previously approved these changes Aug 24, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via 4a912be August 24, 2022 19:58

ranile force-pushed the html_from_raw branch from 55a2558 to 4a912be Compare August 24, 2022 19:58

github-actions bot previously approved these changes Aug 24, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via 83aefe3 August 24, 2022 20:05

github-actions bot previously approved these changes Aug 24, 2022

View reviewed changes

WorldSEnder reviewed Aug 25, 2022

View reviewed changes

packages/yew/src/virtual_dom/vnode.rs Outdated Show resolved Hide resolved

packages/yew/Cargo.toml Outdated Show resolved Hide resolved

ranile dismissed github-actions[bot]’s stale review via ec36c2c August 27, 2022 21:16

github-actions bot previously approved these changes Aug 27, 2022

View reviewed changes

ranile requested a review from WorldSEnder August 27, 2022 21:18

ranile added the breaking change label Aug 27, 2022

ranile dismissed github-actions[bot]’s stale review via 759877a August 27, 2022 21:23

github-actions bot previously approved these changes Aug 27, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via 35b85b9 August 27, 2022 21:25

ranile force-pushed the html_from_raw branch from 759877a to 35b85b9 Compare August 27, 2022 21:25

github-actions bot previously approved these changes Aug 27, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via af33209 August 28, 2022 12:18

github-actions bot previously approved these changes Aug 28, 2022

View reviewed changes

ranile dismissed github-actions[bot]’s stale review via 07dbcf1 August 28, 2022 12:22

github-actions bot previously approved these changes Aug 28, 2022

View reviewed changes

WorldSEnder requested changes Aug 29, 2022

View reviewed changes

packages/yew/src/dom_bundle/braw.rs Show resolved Hide resolved

packages/yew/src/dom_bundle/braw.rs Outdated Show resolved Hide resolved

ranile dismissed github-actions[bot]’s stale review via a7ea1fc September 3, 2022 14:01

ranile added 15 commits November 6, 2022 18:07

Clippy & fmt

6cd8b16

Fix compile errors

f9ecba8

I hope you get attacked by Cow, Clippy

bd89e60

Address review

a6665f2

Reduce DOM calls

68b2d8c

improve detach bundle impl

a5a7787

Add more tests

8fa601b

Update example

8d45239

fmt

e264adf

Apply review suggestions

b69f53e

fmt

4bd8d01

fix ci

dfe7172

fix braw shift with multiple nodes

a498432

rename function name

cb789f6

fmt

117c48f

ranile changed the title ~~Add VNode::html_from_raw~~ Add VNode::from_html_unchecked Nov 6, 2022

ranile dismissed github-actions[bot]’s stale review via 117c48f November 6, 2022 13:11

ranile force-pushed the html_from_raw branch from 166b088 to 117c48f Compare November 6, 2022 13:11

github-actions bot previously approved these changes Nov 6, 2022

View reviewed changes

this should've been there

f2241cc

ranile dismissed github-actions[bot]’s stale review via f2241cc November 6, 2022 13:13

github-actions bot previously approved these changes Nov 6, 2022

View reviewed changes

ci be green

4850d52

ranile dismissed github-actions[bot]’s stale review via 4850d52 November 6, 2022 16:16

github-actions bot approved these changes Nov 6, 2022

View reviewed changes

WorldSEnder approved these changes Nov 7, 2022

View reviewed changes

ranile merged commit 90c7ff1 into yewstack:master Nov 8, 2022

allan2 mentioned this pull request Nov 8, 2022

Next docs visual regression: header not on top #2955

Open

dmeijboom mentioned this pull request Nov 17, 2022

VRaw is not hydratable #2969

Closed

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add VNode::from_html_unchecked #2842

Add VNode::from_html_unchecked #2842

ranile commented Aug 24, 2022 •

edited

Loading

ranile commented Aug 24, 2022

github-actions bot commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading

WorldSEnder left a comment

WorldSEnder left a comment

ranile commented Nov 8, 2022

Add VNode::from_html_unchecked #2842

Add VNode::from_html_unchecked #2842

Conversation

ranile commented Aug 24, 2022 • edited Loading

Description

Checklist

ranile commented Aug 24, 2022

github-actions bot commented Aug 24, 2022 • edited Loading

Benchmark - SSR

Yew Master

Pull Request

github-actions bot commented Aug 24, 2022 • edited Loading

Size Comparison

github-actions bot commented Aug 27, 2022 • edited Loading

WorldSEnder left a comment

Choose a reason for hiding this comment

WorldSEnder left a comment

Choose a reason for hiding this comment

ranile commented Nov 8, 2022

ranile commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 24, 2022 •

edited

Loading

github-actions bot commented Aug 27, 2022 •

edited

Loading