-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reduce SSR Buffers in VList #2826
Conversation
Visit the preview URL for this PR (updated for commit c9de0a0): https://yew-rs-api--pr2826-reduced-buffers-dpb963n6.web.app (expires Sat, 20 Aug 2022 13:53:05 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Benchmark - SSRYew Master
Pull Request
|
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🎉
// boxing to avoid recursion | ||
.boxed_local(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Out of curiosity, what happens this isn't boxed? If the issue is stack overflow, is this something tail recursion can fix?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With Rust’s async/await design, it’s not possible to recursively call async functions without boxing.
https://rust-lang.github.io/async-book/07_workarounds/04_recursion.html
Description
This pull request updates the VList rendering logic that a new buffer is created only when a child VNode does not resolve immediately.
Checklist