-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change access to VList children to a wrapper #2673
Conversation
this should avoid having to manually call recheck_fully_keyed
Visit the preview URL for this PR (updated for commit b700f2f): https://yew-rs-api--pr2673-vlist-children-nnp8i8rr.web.app (expires Tue, 17 May 2022 07:59:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Comparison
✅ None of the examples has changed their size significantly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe it also fixes #1815
@hamza1311 I believe EDIT: will merge this tomorrow, when I had to time to consider #1815 |
VList again has a DerefMut implementation the internal fully_keyed state now has an "indeterminate" variant instead of being a bool, this recomputes it during reconciliation
Description
Fixes #2654
As a response to the confusion in #2654, restrict mutable access to the children of a
VList
to a wrapper that takes care of recomputingfully_keyed
automatically.Checklist