-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement PrivateAgent #2318
Implement PrivateAgent #2318
Conversation
Visit the preview URL for this PR (updated for commit d6b0fe6): https://yew-rs--pr2318-private-agent-14tgaat4.web.app (expires Sat, 08 Jan 2022 14:31:47 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Can you add docs about what a "private" agent is and what's the difference between "public" and "private" agent? |
The doc about private agent is already in master. |
@futursolo In the docs we have
Could you confirm and edit this or you think is is out of scope for this PR? |
This is an old line from the docs of removed job agents. I have updated the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Although I will admit, I'm not too familiar with agents code
Description
Threaded
is renamed intoPublicAgent
PrivateAgent
(It's not possible to have 2
impl<AGN> Threaded for AGN
with a differentReach
).Fixes #1122
Checklist
cargo make pr-flow