Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement PrivateAgent #2318

Merged
merged 3 commits into from
Jan 1, 2022
Merged

Implement PrivateAgent #2318

merged 3 commits into from
Jan 1, 2022

Conversation

futursolo
Copy link
Member

@futursolo futursolo commented Dec 30, 2021

Description

  • Threaded is renamed into PublicAgent
  • Added PrivateAgent
    (It's not possible to have 2 impl<AGN> Threaded for AGN with a different Reach).

Fixes #1122

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • [NA] I have added tests

@github-actions
Copy link

github-actions bot commented Dec 30, 2021

Visit the preview URL for this PR (updated for commit d6b0fe6):

https://yew-rs--pr2318-private-agent-14tgaat4.web.app

(expires Sat, 08 Jan 2022 14:31:47 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@ranile
Copy link
Member

ranile commented Dec 30, 2021

Can you add docs about what a "private" agent is and what's the difference between "public" and "private" agent?

@voidpumpkin voidpumpkin added the A-yew-agent Area: The yew-agent crate label Dec 30, 2021
@futursolo
Copy link
Member Author

Can you add docs about what a "private" agent is and what's the difference between "public" and "private" agent?

The doc about private agent is already in master.

https://yew.rs/docs/next/concepts/agents

@voidpumpkin
Copy link
Member

@futursolo In the docs we have

(TODO verify) When the task is done, the agent will disappear.

Could you confirm and edit this or you think is is out of scope for this PR?

@futursolo
Copy link
Member Author

@futursolo In the docs we have

(TODO verify) When the task is done, the agent will disappear.

Could you confirm and edit this or you think is is out of scope for this PR?

This is an old line from the docs of removed job agents. I have updated the docs.

Copy link
Member

@ranile ranile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Although I will admit, I'm not too familiar with agents code

@siku2 siku2 enabled auto-merge (squash) January 1, 2022 18:44
@siku2 siku2 merged commit 6f6519d into yewstack:master Jan 1, 2022
@futursolo futursolo deleted the private-agent branch January 27, 2022 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew-agent Area: The yew-agent crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Private agents don't implement Threaded
4 participants