Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Classes properties to be created from string literals #2141

Merged
merged 2 commits into from
Nov 11, 2021
Merged

Allow Classes properties to be created from string literals #2141

merged 2 commits into from
Nov 11, 2021

Conversation

jplatte
Copy link
Contributor

@jplatte jplatte commented Nov 11, 2021

Description

Allow Classes component properties to have string literals supplied.

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

ranile
ranile previously approved these changes Nov 11, 2021
View reviewed changes
Copy link
Member

@ranile ranile left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

PS: run cargo make test-overwrite in the packages/yew-macro directory to fix the CI errors

@voidpumpkin voidpumpkin enabled auto-merge (squash) November 11, 2021 20:01
@voidpumpkin voidpumpkin merged commit 39886d4 into yewstack:master Nov 11, 2021
@jplatte jplatte deleted the str-into-prop-value-classes branch November 11, 2021 20:12
@voidpumpkin voidpumpkin added A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate labels Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mc1098 mc1098 mc1098 approved these changes

@voidpumpkin voidpumpkin voidpumpkin approved these changes

@ranile ranile ranile left review comments

Assignees
No one assigned
Labels
A-yew Area: The main yew crate A-yew-macro Area: The yew-macro crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jplatte @voidpumpkin @mc1098 @ranile