Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove underscore prefix for Component trait fns #2010

Merged
merged 1 commit into from
Aug 25, 2021

Conversation

mc1098
Copy link
Contributor

@mc1098 mc1098 commented Aug 25, 2021

Description

Removed underscore prefix for the Component trait fn parameters as this is not IDE friendly.

This was mentioned in another PR.
Fixes #0000

Checklist

  • I have run cargo make pr-flow
  • I have reviewed my own code
  • I have added tests

The Component trait fn definitions don't contain the underscore prefix
as this is not IDE friendly.
@siku2 siku2 merged commit 5b34ce9 into yewstack:master Aug 25, 2021
@mc1098 mc1098 deleted the remove-underscore-prefix branch August 25, 2021 14:34
@voidpumpkin voidpumpkin added the A-yew Area: The main yew crate label Nov 26, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-yew Area: The main yew crate
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants