Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use crypton instead of cryptonite #1838

Merged
merged 2 commits into from
Jul 17, 2024
Merged

Use crypton instead of cryptonite #1838

merged 2 commits into from
Jul 17, 2024

Conversation

ysangkok
Copy link
Contributor

@ysangkok ysangkok commented Jul 10, 2024

Cryptonite has been archived on GitHub, and it has been forked to crypton. See

Tested using

nice cabal build yesod-static yesod-auth -c 'cryptonite<0' -w ghc-9.6.5 -c 'clientsession>=0.9.3.0' -c 'cprng-aes<0'

This depends on

Before submitting your PR, check that you've:

After submitting your PR:

  • Update the Changelog.md file with a link to your PR
  • Check that CI passes (or if it fails, for reasons unrelated to your change, like CI timeouts)

@ysangkok
Copy link
Contributor Author

@psibi It looks like you have maintainer rights for both yesod-auth and yesod-static. Would it be possible for you to review this?

@psibi
Copy link
Member

psibi commented Jul 15, 2024

@ysangkok Looks good to me. Can you see why the CI is failing ?

@ysangkok
Copy link
Contributor Author

@psibi Tests are on par with master now, that is, they only fail on MacOS, for unrelated reasons.

@psibi
Copy link
Member

psibi commented Jul 16, 2024

@ysangkok It looks like that it would require some changes to stack.yaml file for the CI to pass: https://github.com/yesodweb/yesod/actions/runs/9946180395/job/27484737340?pr=1838

@ysangkok
Copy link
Contributor Author

All versions of crypton contain

    if impl(ghc <8.8)
        buildable: False

So the builds for lts-14 can't use crypton.

I see two options:

  1. make the dependency conditional depending on GHC version. So we require cryptonite for ghc<8.8.
  2. remove compatibility for GHC 8.6 and below

@psibi
Copy link
Member

psibi commented Jul 16, 2024

remove compatibility for GHC 8.6 and below

I would lean towards this. CC: @snoyberg if he has any objections.

@snoyberg
Copy link
Member

Agreed

dten added a commit to dten/yesod that referenced this pull request Jul 16, 2024
yesodweb#1838 will drop support for ghc 8.6
jezen pushed a commit that referenced this pull request Jul 16, 2024
* install stack of macos as it is no longer included
ghc 8 not happy no macos-latest
nightly (seemingly there to target 9.0) replaced with higher lts versions

* update checkout version

* no long test on lts-14
#1838 will drop support for ghc 8.6
@psibi psibi merged commit 880b62c into yesodweb:master Jul 17, 2024
6 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants