Upstream helper functions to Yesod.Form.Option. #1828
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 2 new functions are: - optionsFromList': creates an OptionList from a List, using the PathPiece instance for the external value and a custom function for the user-facing value. - optionsEnum': creates an OptionList from an enumeration. Also bump the version and update the changelog.
|
May I request a review from @snoyberg |
snoyberg
reviewed
Nov 30, 2023
|
I think these are quite generally useful — relying on If these functions are too specific for this library, perhaps they can go into some adjacent library, e.g., create a In any case, it isn't immediately obvious (especially to someone newer to Yesod) why they might use these functions, so I would like to see example usage documentation, similar to how it's done in the documentation for the |
|
@jezen more than happy to defer to you on the decision of inclusion |
- Add example usage to optionsFromList'. - Explain optionsEnum' using optionsFromList'. - Add @SInCE tags.
LukeTemp
force-pushed
the
upstream-supercede-form-field-2
branch
from
bf5d1ff to
b1a3b53
Compare
jezen
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The 2 new functions are:
Also bump the version and update the changelog.
Before submitting your PR, check that you've:
After submitting your PR: