Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add README to scaffolded project #169

Merged
merged 2 commits into from
Dec 3, 2017
Merged

Add README to scaffolded project #169

merged 2 commits into from
Dec 3, 2017

Conversation

MaxGabriel
Copy link
Member

Addresses part of #137

I think a README would be a really good addition to the scaffolded project. It would help new users get started, and provide a foundation of documentation for adding other people to your project. IIRC, generating a README is pretty standard other scaffoldings I've seen.

Suggested additions or changes to this README are welcome.

The only potential hassle here is providing database-specific setup instructions.

Copy link
Member

@snoyberg snoyberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one comment. Merge when you're ready :)

Start a development server with:

```
stack exec -- yesod devel
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should probably command on needing to run stack build yesod-bin first.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So that's covered in the Quick Start guide, but I think it would be good to pull the stuff from the QuickStart guide into this README (the quickstart guide hasn't changed that much since the transition to Stack).

The Quickstart guide recommends this command:

stack build yesod-bin cabal-install --install-ghc

Do you know offhand if cabal-install is actually necessary?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cabal-install is no longer necessary, we can remove that recommendation.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, saw you removed it from the quickstart guide as well 👍

README.md Outdated
stack test --flag PROJECTNAME_LOWER:library-only --flag PROJECTNAME_LOWER:dev
```

(Because `yesod devel` passes the `library-only` and `dev` flags, matching those flags means you don't need to recompile between tests and development, and it disables optimization to speed up your tests).
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@snoyberg Is there a way Stack can default stack test to use these flags, so they don't need to be specified on the command line?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately not. A somewhat funny approach we could consider is adding a Makefile with targets like devel and test. I've seen a number of people doing this recently.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hm ok, something to consider then

@snoyberg snoyberg merged commit a901b4f into postgres Dec 3, 2017
@snoyberg
Copy link
Member

snoyberg commented Dec 3, 2017

Thanks!

@snoyberg snoyberg deleted the addREADME branch December 3, 2017 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants