Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example of wai-cors configuration #2

Merged
merged 1 commit into from
Dec 3, 2015
Merged

Conversation

marcenuc
Copy link
Contributor

@marcenuc marcenuc commented Dec 1, 2015

wai-cors package documentation does not explain how to configure it in Yesod.

Here's some more details.

[`wai-cors` package documentation](https://hackage.haskell.org/package/wai-cors) does not explain how to configure it in Yesod.

Here's some more details.
@marcenuc
Copy link
Contributor Author

marcenuc commented Dec 2, 2015

I have just found that the same info as this cookbook are also on the following wiki page: https://github.com/yesodweb/yesod/wiki/Allowing-WOFF-fonts-to-be-accessed-from-other-domains-%28CORS%29

Should I fix the wiki page or the cookbook?

I think we should remove one or the other, because it is confusing for newcomers and it is difficult to keep it updated.

snoyberg added a commit that referenced this pull request Dec 3, 2015
Example of wai-cors configuration
@snoyberg snoyberg merged commit 14c1ba4 into yesodweb:master Dec 3, 2015
@snoyberg
Copy link
Member

snoyberg commented Dec 3, 2015

Thanks! I'd recommend removing the content on the wiki page and pointing to the cookbook.

@marcenuc
Copy link
Contributor Author

marcenuc commented Dec 4, 2015

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants