Migrate crypto-aes and cprng-aes to cryptonite. #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crypto-aes's encryption now fail on my machine with Illegal Instruction errors, and the package has been deprecated in favor of cryptonite for years, so migrate to that. cprng-aes is an indirect dependency on crypto-aes. cryptonite doesn't offer an AES-based CPRNG, but its ChaCha-based one has the closest interface.
|
@jmazon : Maybe you can port this PR to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto-aes's encryption now fails on my machine with Illegal Instruction errors, and the package has been deprecated in favor ofcryptonitefor years, so migrate to that.cprng-aesis an indirect dependency oncrypto-aes.cryptonitedoesn't offer an AES-based CPRNG, but its ChaCha-based one has the closest interface, so I used that.The former code has a comment L308 (patched file line numbers) regarding RNG performance. I do not know the referenced benchmark's whereabouts, so I'm delegating that to someone in the know (or signalling for clean-up).
stack (or ghc or cabal) failed to build at stack.yaml's specified lts-6.6, so I tested on lts-19.29.