Add option to run field-specific pipelines in search #153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeraydiazdiaz
force-pushed
the
run_field_pipelines
branch
from
1c4df47
to
7490868
Compare
|
Hi @dhdaines, I'm finally getting around to checking your PRs. Seems this one is failing Black, could you rebase, run the formatter, and resubmit? |
|
Thanks! I think I have a different version of Black installed in Emacs. I'm going to take a second look at this one because as noted it breaks bug-compatibility. It would be nice to have the option to do this though. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #153 +/- ##
==========================================
+ Coverage 96.02% 96.10% +0.07%
==========================================
Files 48 48
Lines 3171 3209 +38
==========================================
+ Hits 3045 3084 +39
+ Misses 126 125 -1 ☔ View full report in Codecov by Sentry. |
dhdaines
force-pushed
the
run_field_pipelines
branch
from
77fa041
to
0e43cd0
Compare
dhdaines
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #152
but this will break bug-compatibility with lunr.jsbut make the fixed behaviour optional so as not to break bug-compatibility.