Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support linting html in template literals #238

Merged
merged 10 commits into from
Dec 1, 2024

Conversation

yeonjuan
Copy link
Owner

@yeonjuan yeonjuan commented Nov 30, 2024

#225
Applying template-parser to the rules
- no-accesskey-attrs
- no-aria-hidden-body
- no-duplicate-id
- no-restricted-attrs
- no-restricted-attr-values
- no-positive-tabindex
- no-script-style-type
- no-target-blank
- quotes
- require-attrs
- require-button-type
- require-closing-tags
- require-frame-title
- require-img-alt
- require-lang
- sort-attrs

@yeonjuan yeonjuan marked this pull request as ready for review December 1, 2024 09:16
@yeonjuan yeonjuan merged commit ed2a3b3 into main Dec 1, 2024
5 checks passed
@yeonjuan yeonjuan deleted the 225/no-accesskey-attrs branch December 1, 2024 09:23
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 95.62044% with 6 lines in your changes missing coverage. Please review.

Project coverage is 98.32%. Comparing base (c9651f9) to head (4f7a867).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ges/eslint-plugin/lib/rules/no-restricted-attrs.js 81.81% 4 Missing ⚠️
...ackages/eslint-plugin/lib/rules/no-duplicate-id.js 96.55% 1 Missing ⚠️
...lint-plugin/lib/rules/no-restricted-attr-values.js 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #238      +/-   ##
==========================================
- Coverage   98.34%   98.32%   -0.03%     
==========================================
  Files          57       57              
  Lines        1453     1494      +41     
  Branches      399      407       +8     
==========================================
+ Hits         1429     1469      +40     
- Misses         24       25       +1     
Flag Coverage Δ
unittest 98.32% <95.62%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...ages/eslint-plugin/lib/rules/no-accesskey-attrs.js 100.00% <100.00%> (ø)
...ges/eslint-plugin/lib/rules/no-aria-hidden-body.js 100.00% <100.00%> (ø)
...es/eslint-plugin/lib/rules/no-positive-tabindex.js 100.00% <100.00%> (ø)
...es/eslint-plugin/lib/rules/no-script-style-type.js 100.00% <100.00%> (ø)
...ackages/eslint-plugin/lib/rules/no-target-blank.js 100.00% <100.00%> (ø)
packages/eslint-plugin/lib/rules/quotes.js 97.61% <100.00%> (+0.05%) ⬆️
packages/eslint-plugin/lib/rules/require-attrs.js 100.00% <100.00%> (ø)
...ges/eslint-plugin/lib/rules/require-button-type.js 100.00% <100.00%> (ø)
...es/eslint-plugin/lib/rules/require-closing-tags.js 98.21% <100.00%> (+0.03%) ⬆️
...ges/eslint-plugin/lib/rules/require-frame-title.js 100.00% <100.00%> (ø)
... and 6 more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant