This repository has been archived by the owner on Apr 20, 2018. It is now read-only.
Added regular expressions to update the name of svg files included with the AngularJS ngInclude element and attribute #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…th AngularJS ngInclude element and attribute
|
Can you include tests? Also need to fix the merge conflict. |
| + ], | ||
| + [ /<ng-include[^]+src=['"]([^"']+svg)["']/gm, | ||
| + 'Update the HTML with the new svg filenames included with ngInclude element' | ||
| + ], |
There was a problem hiding this comment.
remove the +s on the left side ;)
|
You can use the new feature in #337 to solve this yourself. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AngularJS allows for the inclusion of svg files in the html as
svgelements by using thengIncludedirective.Currently, svg files included in the html with this technique are not processed by
useminas they don't match any of the regular expressions infileprocessor.js. Consequently their names are not updated in the html after therevphase.I have included regular expressions that match
ngIncludedirectives with an svg image as soure.