Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

grunt-usemin is DEPRECATED :( #514

Closed
stevemao opened this issue Feb 12, 2015 · 21 comments
Closed

grunt-usemin is DEPRECATED :( #514

stevemao opened this issue Feb 12, 2015 · 21 comments

Comments

@stevemao
Copy link
Contributor

I teared up when I saw this and instinctively tried to find an alternative (a even better tool I was hoping). I searched all the opening issues but found none related to the deprecation. I'm not sure if we should continue using any other tool to do the same job or we should go back to configure cssmin, uglify, concat and filerev manually.

A lot of Yeoman generators are still using grunt-usmin and I'm sure I will feel nostalgic every time I open my Gruntfile.js.

@sindresorhus
Copy link
Member

It's still useable, the problem is that nobody is interested in maintaining it. We've tried for more than a year to get a maintainer, but the issues and PRs just keeps piling up...

#313

@stephanebachelier
Copy link
Collaborator

@sindresorhus I'm not very active for the moment but I plan to put a little more energy on this repo. It's the central piece for lots of my works and there are no known pieces of software that does what usemin do.

@eddiemonge
Copy link
Member

Removed the deprecated notice but if its still orphaned in a few months Ill be sad. Of course I could spend more time helping on it.

@sindresorhus
Copy link
Member

If nothing more has happened in a few months I will deprecate it for real. Not doing so would be an disservice to users.

@stephanebachelier
Copy link
Collaborator

@sindresorhus I have started to review issues and tagging issues with the following labels:

  • docs which I've started to explain in Documenting some issues by creating a wiki #519
  • question for any issues that need a discussion
  • codereview when the issue is waiting for a PR to be merged
  • waiting for any feedback needed
  • feature when this is about adding something to usemin, like switching to HTML parser (under investigation)

My feeling is that most issues will be tagged by waiting or docs.

Feel free to renamed any label.

@arthurvr
Copy link
Member

@stephanebachelier You're on fire! 🔥 Doing great man!

@stephanebachelier
Copy link
Collaborator

@arthurvr :)

@stevemao
Copy link
Contributor Author

stevemao commented Mar 2, 2015

@stephanebachelier it might be easier if you merge similar issues just to make it easier to manage.

@stephanebachelier
Copy link
Collaborator

@stevemao you're right and I've started to add the label duplicate on some issues.
But some of them are more variants of the same problem.

@arthurvr
Copy link
Member

arthurvr commented Jun 8, 2015

If nothing more has happened in a few months I will deprecate it for real. Not doing so would be an disservice to users.

@sindresorhus The latest commit to the dev branch was April 13 so sadly I start to believe we should really do it.

Don't have anything to say about this task at all, but it's indeed a disservice and kind of a pain. I also start to believe we don't only need an active maintainer but we need a rewrite.

@stevemao
Copy link
Contributor Author

stevemao commented Jun 8, 2015

we need a rewrite.

👍

@stephanebachelier
Copy link
Collaborator

@arthurvr I was kept by client projects and not being able to work on open source projects. I will soon have time to work again on dev branch, and first fix my PRs.

By the way it's not so easy because there are not a lot of activity and no real code review.
Some guys don't seem to care about being reviewed, and I can go the same way on the dev branch. At least I will be happy to continue my effort without waiting most of the time in hope for a code review.

we need a rewrite

@stevemao it's already being done in the dev branch, with the addition of HTML parser. If somebody wants to help with some tests against some major yeoman generators it would be great.

I've even though about forking grunt-usemin and going the way I think, because as already said before all my projects depends on grunt-usemin, and due to lack of activity.

@stevemao
Copy link
Contributor Author

@stephanebachelier Sorry didn't know the dev branch is the rewrite. Will try out in some projects. Thanks.

@stevemao
Copy link
Contributor Author

@stephanebachelier I think you can propose your ideas and let people see if they are good. Since there's no active maintainers its ok to try something crazy.

@arthurvr
Copy link
Member

At least I will be happy to continue my effort without waiting most of the time in hope for a code review.

👍 You can still ask us to code review the whole dev branch once we want to land it on master.

it's already being done in the dev branch,

@stephanebachelier That's not being done there. There are big changes going on there but not really the changes we originally planned to do in the rewrite.

@stephanebachelier
Copy link
Collaborator

@arthurvr it's the first I see this issue (closed) and requirement list about usemin rewrite!

@arthurvr
Copy link
Member

@stephanebachelier @sindresorhus @eddiemonge So what's the long term plan? Do we want to stay developing this as-is in the dev branch? Do we want to look into finally cleaning up and doing the big rewrite we ever planned out a long time ago?

I'm not sure what the best thing to do with this task. Using the current API it's a pain to maintain (even if we're able to get rid of the regexes)

@eddiemonge
Copy link
Member

I think we should find a way to split it up into smaller, more maintainable modules and then have this as a wrapper that pulls them in. Each of those smaller modules could be rewritten cleanly. Then we could probably eventually fade this out in favor of the other modules.
I think @sindresorhus might agree with this approach.

@stephanebachelier
Copy link
Collaborator

@arthurvr @eddiemonge I agree with a complete rewrite with more maintainable modules. Much better than the current base code. I was trying to pull into a better direction with dev branch but it will be much easier to rewrite from scratch.

@frankstallone
Copy link

Someone point me to the tip jar, please!

@fatso83
Copy link

fatso83 commented Mar 30, 2016

Over the last month there have been several people that has stepped up in #313 that would like to help maintain this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants