Skip to content
This repository has been archived by the owner on Apr 20, 2018. It is now read-only.

Help with maintainance #313

Open
addyosmani opened this issue Mar 9, 2014 · 35 comments
Open

Help with maintainance #313

addyosmani opened this issue Mar 9, 2014 · 35 comments
Labels

Comments

@addyosmani
Copy link
Member

If you heavily use or have used grunt-usemin, we would like to ask if you might be interested in helping us maintain this task. As you can probably tell by the PR queue and questions about the project, it's used by many but needs active weekly review of threads and code we might like to land back to the project.

The rest of the Yeoman team are currently focusing on generators, docs and our next version of the project so any help at all would be hugely appreciated.

@addyosmani
Copy link
Member Author

@sleeper
Copy link
Contributor

sleeper commented Mar 10, 2014

Yes, sorry for that :(
Last months have been quite packed both in professional and personal world ...
Will try to merge some in the following days ;)

@halkeye
Copy link
Contributor

halkeye commented Mar 10, 2014

I'll see what I can contribute, but I don't really use this module enough to feel like I could help with maintenance. I'll totally continue to submit PRs though.

@akinofftz
Copy link
Contributor

Well, the project I've used usemin has been finished and I went to something new, but if there are bugs, I can look what I can do.

@addyosmani
Copy link
Member Author

Thank you!

@addyosmani
Copy link
Member Author

We've landed some necessary fixes to grunt-usemin and I've tagged the first release of it we've had in 6 months. Tests are passing but any help you can offer with trying out the latest build would be very useful.

@sindresorhus
Copy link
Member

Just wanted to add that we're still looking for help managing this repo. Triaging issues, reviewing PRs, fixing things. Any help welcome :)

@stephanebachelier
Copy link
Collaborator

@sindresorhus I use usemin a lot. I will take a look at some issues to see if I can help. But no promises :/

@donaldpipowitch
Copy link
Contributor

I would really love to do this, but I don't have enough spare time for that. Will try to help with further pull requests :/

@vladikoff
Copy link
Contributor

@addyosmani would be happy to help, let me know.

@sindresorhus
Copy link
Member

@stephanebachelier @donaldpipowitch @vladikoff Added you to the repo. Feel free to commit, triage issues and review/merge PRs. No pressure though :)

@addyosmani
Copy link
Member Author

Huge thanks to anyone who has offered their help. Usemin gets used quite a lot and unfortunately, we don't have as much time as we would like to maintain it. If you'd like to help with the list of tasks Sindre mentioned above we'd <3 it. Let us know if you need anything when it comes to tagging/pushing new releases.

@stephanebachelier
Copy link
Collaborator

@addyosmani I've read through some of it. I'll take some time to help with some issues.

Usemin is the central piece of my workflow :)

@sudevkk
Copy link

sudevkk commented Aug 5, 2014

Will try to help with some issues. Let me go through the Issue list. Any priorities ?

@sindresorhus
Copy link
Member

@sudevkk Reviewing PRs has priority. Other than that. Go nuts :)

@eddiemonge
Copy link
Member

If anyone has any questions or is hesitant about closing an issue, landing a PR or any other questions ping @sindresorhus or me or any Yeoman core member and we will step in and provide direction. Thanks for volunteering

@jamesscholeyweb
Copy link
Contributor

I should have some free time to take a look and help where I can.

@alimd
Copy link

alimd commented Oct 9, 2014

yes. thank you.

@arthurvr
Copy link
Member

I'm def. interested in trying to help out, btw. Maintaining seems a little much, but helping, for sure.

@jfroffice
Copy link

👍 if I can help to review some PR or fix some issues.

@shamoons
Copy link

I'm happy to take on as maintainer.

@karensg
Copy link

karensg commented Mar 20, 2016

That would be great! Lots of pull requests are waiting review :)

@nodox
Copy link

nodox commented Mar 22, 2016

Would love to take on as another maintainer.

@ptitgraig
Copy link

@addyosmani @sindresorhus, some people seems to be keen on maintaing this project :)

@sindresorhus
Copy link
Member

@shamoons @karensg @nodox @ptitgraig Thanks for stepping up. You're now collaborators on this repo :)

The guidelines are simple. Be kind to everyone. Larger changes should come in a pull request. Smaller ones can be committed directly. Pull requests should have at least one 👍 from another collaborator before being merged. Follow the existing code style and ensure npm test passes before pushing a commit. You can use branches in this repo, but clean them up afterwards. Bugs fixes and new features should come with tests. We prefer a clean commit history, so when merging a pull request, either ask the contributor to squash their commits or do it for them manually.

Also keep in mind that the goal of this project is simplicity. That means solving a problem for the 90% with the least amount of options.

The next step and biggest priority is to land @stephanebachelier's dev branch which resolves #244.

@eddiemonge
Copy link
Member

Or make this a thin wrapper around useref and combine the efforts with @jonkemp to reduce duplication

@nodox
Copy link

nodox commented Apr 7, 2016

What needs to happen before @stephanebachelier dev branch can be merged? Are we missing tests?
@sindresorhus

@sindresorhus
Copy link
Member

@nodox I don't know. You'll have to ask him.

@eddiemonge
Copy link
Member

Someone just needs to go through it and make sure it works and merges cleanly

@stephanebachelier
Copy link
Collaborator

@sindresorhus @eddiemonge I'm back in the place. For the dev branch I had asked if anybody could tested it but I don't know about anyone apart from me.
I will take a look again at the dev branch. It should still works.

Is there some forum / place to discuss about what to do ? I created the gitter yeoman/grunt-usemin channel last year but there is not so much activity :) Have you got another channel ?

@sindresorhus
Copy link
Member

Yes, you can use https://gitter.im/yeoman/yeoman (Maybe add that to the readme).

@stephanebachelier
Copy link
Collaborator

@sindresorhus ok done.

@benmcginnis
Copy link

still need any help @addyosmani and @sindresorhus ?

@sindresorhus sindresorhus mentioned this issue Jun 16, 2016
@sovaj
Copy link

sovaj commented Jan 7, 2017

I like to help you guys

Let me know if you still looking for someone to maintain this project. If you do I will gladly do it.

Thanks.

@eddiemonge
Copy link
Member

Yup still are. What capacity would you like to help in?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests