Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DefaultHost.java:352-355: We should be caching the... #186

Closed
davvd opened this issue Jun 30, 2014 · 4 comments
Closed

DefaultHost.java:352-355: We should be caching the... #186

davvd opened this issue Jun 30, 2014 · 4 comments
Labels
30 mins @carlosmiranda

Comments

@davvd
Copy link

davvd commented Jun 30, 2014

Puzzle 173-e3a77fb4 in s3auth-hosts/src/main/java/com/s3auth/hosts/DefaultHost.java:352-355 has to be resolved: We should be caching the results of this method for a short period somehow, or at least prevent unnecessary repeated requests to Amazon CloudWatch API. This is so that we can improve performance and reduce access costs.
@davvd
Copy link
Author

davvd commented Jun 30, 2014

@carlosmiranda please proceed, it's yours

carlosmiranda added a commit to carlosmiranda/s3auth that referenced this issue Jul 1, 2014
@carlosmiranda
yegor256#186 Cached retrieval of CloudWatch stats
ee865f5
@carlosmiranda
Copy link
Collaborator

Pull request has been created in #187.

ghost pushed a commit that referenced this issue Jul 2, 2014
Merge pull request #187 from carlosmiranda/186
5ce592b 
#187: pull request #186 Cached retrieval of CloudWatch stats
@davvd davvd closed this as completed Jul 4, 2014
@davvd
Copy link
Author

davvd commented Jul 4, 2014

Closing..

@davvd
Copy link
Author

davvd commented Jul 4, 2014

@carlosmiranda Thanks so much! Your account was topped up for 30 mins (transaction ID is 41583289)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
30 mins @carlosmiranda
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@carlosmiranda @davvd