Github hook's handling fails with a 503 error #572

nergal-perm · 2024-02-09T12:34:08Z

After fixing #567 I am able to see my puzzles again, but now 0pdd web service answers with HTTP code 503 to all the POST requests (Github hooks). The response body contains an HTML with the following error:

undefined method `rewind' for #<Rackup::Handler::WEBrick::Input:0x00007f119add5b28  // here is a huge wall of text, see attached TXT file

  request.body.rewind
              ^^^^^^^
	/app/0pdd.rb:353:in `block in <top (required)>'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `block in compile!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (3 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1089:in `route_eval'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (2 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1120:in `block in process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1069:in `block in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `each'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1190:in `block in dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1185:in `dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `block in call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:990:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/deflater.rb:47:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/xss_header.rb:20:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/path_traversal.rb:18:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/json_csrf.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/frame_options.rb:33:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/logger.rb:19:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/common_logger.rb:43:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:266:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:259:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/head.rb:15:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/method_override.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:224:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:2115:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `block in call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1890:in `synchronize'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rackup-2.1.0/lib/rackup/handler/webrick.rb:111:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:140:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:96:in `run'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/server.rb:310:in `block in start_thread'

So, right now no added/removed puzzle markers are handled for my project (https://github.com/nergal-perm/java-decita).

Attachments:

error.txt - an HTML with the error stacktrace
request.json - the content of the github hook request

The text was updated successfully, but these errors were encountered:

yegor256 · 2024-02-09T12:52:10Z

@pnatashap maybe you can help?

pnatashap · 2024-02-09T14:44:06Z

rewind is deleted also from rack 3.0, will check for hotfix
rack/rack#1972

[#572] add RewindableInput for rewind

h1alexbel · 2024-02-12T12:56:27Z

the same

pnatashap · 2024-02-12T23:32:10Z

fix is merged but not released
@yegor256 may be new release is needed?

yegor256 · 2024-02-13T04:07:17Z

@rultor release, tag is 0.31.11

rultor · 2024-02-13T04:09:18Z

@rultor release, tag is 0.31.11

@yegor256 OK, I will release it now. Please check the progress here

yegor256 · 2024-02-13T05:18:11Z

@rultor stop

rultor · 2024-02-13T05:19:19Z

@rultor stop

@yegor256 OK, I'll try to stop current task.

yegor256 · 2024-02-13T05:19:36Z

@rultor release, tag is 0.31.11

rultor · 2024-02-13T05:19:42Z

@rultor stop

@nergal-perm @yegor256 Sorry, I failed to stop the previous command, however it has the following result: Oops, I failed. You can see the full log here (spent 1hr)

rultor · 2024-02-13T05:22:50Z

@rultor release, tag is 0.31.11

@yegor256 OK, I will release it now. Please check the progress here

rultor · 2024-02-13T05:26:01Z

@rultor release, tag is 0.31.11

@nergal-perm @yegor256 Oops, I failed. You can see the full log here (spent 3min)

yegor256 · 2024-02-13T05:27:10Z

@pnatashap I released a new version manually

nergal-perm · 2024-02-13T08:42:13Z

@yegor256 , @pnatashap , the result is still 503, but the error text changed:



no implicit conversion of nil into String
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `initialize'
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `new'
	/app/vendor/bundle/ruby/3.1.0/gems/json-2.7.1/lib/json/common.rb:219:in `parse'
	/app/0pdd.rb:359:in `block in <top (required)>'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1804:in `block in compile!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (3 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1089:in `route_eval'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1071:in `block (2 levels) in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1120:in `block in process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1118:in `process_route'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1069:in `block in route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `each'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1066:in `route!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1190:in `block in dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1185:in `dispatch!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `block in call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `catch'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1161:in `invoke'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1001:in `call!'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:990:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/rewindable_input.rb:25:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/deflater.rb:47:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/xss_header.rb:20:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/path_traversal.rb:18:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/json_csrf.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/base.rb:53:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-protection-4.0.0/lib/rack/protection/frame_options.rb:33:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/logger.rb:19:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/common_logger.rb:43:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:266:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:259:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/head.rb:15:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rack-3.0.9/lib/rack/method_override.rb:28:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:224:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:2115:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `block in call'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1890:in `synchronize'
	/app/vendor/bundle/ruby/3.1.0/gems/sinatra-4.0.0/lib/sinatra/base.rb:1674:in `call'
	/app/vendor/bundle/ruby/3.1.0/gems/rackup-2.1.0/lib/rackup/handler/webrick.rb:111:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:140:in `service'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/httpserver.rb:96:in `run'
	/app/vendor/bundle/ruby/3.1.0/gems/webrick-1.8.1/lib/webrick/server.rb:310:in `block in start_thread'

yegor256 · 2024-02-13T10:07:12Z

@nergal-perm new version released, please try again (changes: a627116)

nergal-perm · 2024-02-13T11:28:21Z

@yegor256 HTTP code 400, error message is URL-encoded content is expected in the "payload" query parameter, but it is not provided when trying to redeliver last github webhook

yegor256 · 2024-02-13T11:34:06Z

@nergal-perm this message is a pretty reasonable one. Are you sending this POST request manually or through Github webhook?

nergal-perm · 2024-02-13T11:36:05Z

I've tried it both ways - manually and redelivering last unsuccessful Github webhook. Both gave that response.

I should try to push some commits to master branch and trigger the webhook in "usual" way, though.

yegor256 · 2024-02-13T11:38:28Z

@nergal-perm if it fails, please attach a screenshot from Github webhooks page

nergal-perm · 2024-02-13T11:41:29Z

request payload

Failed.
Screenshots and the payload attached.

yegor256 · 2024-02-13T13:04:43Z

@nergal-perm as a temporary solution, use this URL for webhook: https://www.0pdd.com/hook/github In the meantime, I will investigate why rehttp doesn't pass the payload through.

nergal-perm · 2024-02-17T06:58:04Z

@yegor256 , it's all the same, seems that problem is not in the rehttp service.

pnatashap · 2024-02-18T03:26:01Z

@nergal-perm workaround is to change content-type for webhook to application/json (and can return back rehttp). It will work in both cases, will check what happens with application/x-www-form-urlencoded message type, params are really not parsed

0pdd · 2024-03-18T20:45:47Z

@nergal-perm the puzzle #591 is still not solved.

pnatashap added a commit to pnatashap/0pdd that referenced this issue Feb 9, 2024

[yegor256#572] add Rack::RewindableInput::Middleware to rewind

30f117e

pnatashap added a commit to pnatashap/0pdd that referenced this issue Feb 9, 2024

[yegor256#572] add a puzzle

3cd6299

pnatashap added a commit to pnatashap/0pdd that referenced this issue Feb 9, 2024

[yegor256#572] add a puzzle

60a80af

yegor256 added a commit that referenced this issue Feb 12, 2024

Merge pull request #574 from pnatashap/572

9b9e8f0

[#572] add RewindableInput for rewind

yegor256 added a commit that referenced this issue Feb 13, 2024

push #572 check for empty payload

a627116

0pdd mentioned this issue Mar 18, 2024

0pdd.rb:152-153: rewind is removed from rack 3.0, so it... #591

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Github hook's handling fails with a 503 error #572

Github hook's handling fails with a 503 error #572

nergal-perm commented Feb 9, 2024

yegor256 commented Feb 9, 2024

pnatashap commented Feb 9, 2024

h1alexbel commented Feb 12, 2024

pnatashap commented Feb 12, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

rultor commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 •

edited

Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 •

edited

Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 •

edited

Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 17, 2024

pnatashap commented Feb 18, 2024

0pdd commented Mar 18, 2024

Github hook's handling fails with a 503 error #572

Github hook's handling fails with a 503 error #572

Comments

nergal-perm commented Feb 9, 2024

yegor256 commented Feb 9, 2024

pnatashap commented Feb 9, 2024

h1alexbel commented Feb 12, 2024

pnatashap commented Feb 12, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

rultor commented Feb 13, 2024

rultor commented Feb 13, 2024

rultor commented Feb 13, 2024

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 • edited Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 • edited Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 13, 2024 • edited Loading

yegor256 commented Feb 13, 2024

nergal-perm commented Feb 17, 2024

pnatashap commented Feb 18, 2024

0pdd commented Mar 18, 2024

nergal-perm commented Feb 13, 2024 •

edited

Loading

nergal-perm commented Feb 13, 2024 •

edited

Loading

nergal-perm commented Feb 13, 2024 •

edited

Loading