-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Geo format type wrappers and generic methods #97
Conversation
9fe4b8e
to
e216f89
Compare
To my knowledge, the spatial projection tests that we have are defined in the following files: |
Ok this is is tested, it just has to wait for the new version of GeoFormatTypes to go into the registry for tests to pass.
I'll rebase it against the other pull request once that's in, but otherwise this is done, so comments would be useful. |
This is rebased and passing now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR!
It seems to involve changes not just to the projections, but also to the Geometries right now, so I'll like to have a second pass at it after the requested changes.
Ok I think this is pretty much finished, sorry for the delay! I've been using it for a few months in GeoData.jl and it's working well. |
It looks great, thanks a lot! :) |
Thanks! I can relegister GeoData.jl whenever this is registered. |
@rafaqz it will be registered in a few minutes: JuliaRegistries/General#12666 |
No tests yet, but things like
reproject
do work for any format types, which is pretty powerful allready.I'm not really familiar with the details of these formats or GDAL methods, so input on how to actually test these things and finish the PR will be needed.
My intent (and knowledge) is more around generalising the structure of these package and the ecosystem so we can do all kinds of transformations without needing all the method permutations everywhere.
For GeoData.jl this PR allows us to do
GDALarray(filepath; reproject=EPSGcode(4326))
where you can pass in anything for reproject and GeoData doesn't need to know what it is, but your lat/lon coords will just work.The type wrappers are coming from https://github.com/rafaqz/GeoFormatTypes.jl