Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert any geometries to gdal types in geometry methods #366

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

convert any geometries to gdal types in geometry methods #366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
d1e8df0
convert any geometries to gdal types in geometry methods
rafaqz Jan 18, 2023
bf4ed42
updates
rafaqz Feb 22, 2023
bc2c98e
updates
rafaqz Feb 22, 2023
84f3955
passing tests
rafaqz Feb 24, 2023
dad78b4
fix
rafaqz Mar 27, 2023
006b5ee
test more on geointerface objects
rafaqz Apr 22, 2023
4cb3d8a
test more methods
rafaqz Apr 23, 2023
67aa8b9
dont add unsafe methods
rafaqz Apr 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 18 additions & 10 deletions src/geointerface.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ const lookup_method = Dict{DataType,Function}(
GeoInterface.MultiLineStringTrait => createmultilinestring,
GeoInterface.PolygonTrait => createpolygon,
GeoInterface.MultiPolygonTrait => createmultipolygon,
GeoInterface.GeometryCollectionTrait => creategeomcollection,
)

let pointtypes = (wkbPoint, wkbPoint25D, wkbPointM, wkbPointZM),
Expand Down Expand Up @@ -280,18 +281,25 @@ let pointtypes = (wkbPoint, wkbPoint25D, wkbPointM, wkbPointZM),
return toWKT(geom)
end

function GeoInterface.convert(
::Type{T},
type::GeometryTraits,
geom,
) where {T<:IGeometry}
f = get(lookup_method, typeof(type), nothing)
isnothing(f) && error(
"Cannot convert an object of $(typeof(geom)) with the $(typeof(type)) trait (yet). Please report an issue.",
)
return f(GeoInterface.coordinates(geom))
function GeoInterface.convert(::Type{T}, trait::GeometryTraits, geom) where {T<:IGeometry}
f = get(lookup_method, typeof(trait), nothing)
isnothing(f) && _convert_error(geom, trait)
coords = GeoInterface.coordinates(geom)
return f(coords)
end

function GeoInterface.convert(::Type{T}, trait::GeoInterface.GeometryCollectionTrait, collection) where {T<:IGeometry}
gdal_collection = creategeomcollection()
for geom in GeoInterface.getgeom(collection)
addgeom!(gdal_collection, to_gdal(geom))
end
return gdal_collection
end

@noinline _convert_error(geom, trait) = error(
"Cannot convert an object of $(typeof(geom)) with the $(typeof(trait)) trait (yet). Please report an issue at https://github.com/yeesian/ArchGDAL.jl if you need this",
)

function GeoInterface.geomtrait(
geom::Union{map(T -> AbstractGeometry{T}, pointtypes)...},
)
Expand Down
Loading