Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Family Signup Form Styling Update #950

Merged
merged 14 commits into from
Nov 14, 2024

Conversation

lucasxsong
Copy link
Collaborator

@lucasxsong lucasxsong commented Nov 13, 2024

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@lucasxsong lucasxsong requested a review from a team as a code owner November 13, 2024 00:02
Copy link

github-actions bot commented Nov 13, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.1% 390 / 7637
🔵 Statements 5% 421 / 8412
🔵 Functions 6.12% 115 / 1878
🔵 Branches 2.41% 110 / 4564
File Coverage
File Stmts Branches Functions Lines Uncovered Lines
Changed Files
src/components/auth/RegisterParent.vue 0% 0% 0% 0% 182-149
src/pages/RegisterFamilyUsers.vue 0% 0% 0% 0% 91-65
src/router/index.js 0% 0% 0% 0% 8-488
Generated in workflow #916 for commit 25a31d7 by the Vitest Coverage Report Action

Copy link

github-actions bot commented Nov 13, 2024

Visit the preview URL for this PR (updated for commit 25a31d7):

https://roar-staging--pr950-enh-parent-signup-li-rq942bly.web.app

(expires Thu, 21 Nov 2024 18:08:11 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Nov 13, 2024

roar-dashboard-e2e    Run #9138

Run Properties:  status check passed Passed #9138  •  git commit 25a31d7399: E2E Tests for PR 950 "Family Signup Form Styling Update" from commit "25a31d7399...
Project roar-dashboard-e2e
Branch Review enh/parent-signup-lightweight-refactor
Run status status check passed Passed #9138
Run duration 03m 28s
Commit git commit 25a31d7399: E2E Tests for PR 950 "Family Signup Form Styling Update" from commit "25a31d7399...
Committer Lucas Song
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

@Emily-ejag
Copy link
Contributor

Could you please put the 6 characters password required on the kid :) Also, cleverSignIn is failing

Copy link
Contributor

@Emily-ejag Emily-ejag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please put the 6 characters password required on the kid side

Emily-ejag
Emily-ejag previously approved these changes Nov 13, 2024
@lucasxsong lucasxsong force-pushed the enh/parent-signup-lightweight-refactor branch from ced411f to e12c851 Compare November 13, 2024 18:24
Emily-ejag
Emily-ejag previously approved these changes Nov 13, 2024
Emily-ejag
Emily-ejag previously approved these changes Nov 13, 2024
Emily-ejag
Emily-ejag previously approved these changes Nov 13, 2024
kellyel
kellyel previously approved these changes Nov 14, 2024
@lucasxsong lucasxsong merged commit 07e9084 into main Nov 14, 2024
24 checks passed
@lucasxsong lucasxsong deleted the enh/parent-signup-lightweight-refactor branch November 14, 2024 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-alignment enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants