Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the meta description #910

Merged
merged 1 commit into from
Oct 28, 2024
Merged

Update the meta description #910

merged 1 commit into from
Oct 28, 2024

Conversation

kellyel
Copy link
Collaborator

@kellyel kellyel commented Oct 25, 2024

Proposed changes

Updates the website's user-facing description
image

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@kellyel kellyel requested a review from a team as a code owner October 25, 2024 20:26
Copy link

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.07% 390 / 7687
🔵 Statements 4.97% 421 / 8462
🔵 Functions 6.09% 115 / 1888
🔵 Branches 2.41% 110 / 4552
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/App.vue 0% 0% 0% 0% 33, 33-36, 35, 35, 42-44, 46-47, 49-53, 50-52, 55, 55, 57, 59-85, 87-105, 88, 90-102, 94-97, 95-96, 98-101, 99-100, 104, 107-118, 108-109, 111-117, 112-117, 114-116, 115
Generated in workflow #783 for commit b9d054b by the Vitest Coverage Report Action

Copy link

github-actions bot commented Oct 25, 2024

Visit the preview URL for this PR (updated for commit b9d054b):

https://roar-staging--pr910-enh-update-desc-8hewjdy5.web.app

(expires Fri, 01 Nov 2024 20:30:26 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Oct 25, 2024

roar-dashboard-e2e    Run #8610

Run Properties:  status check passed Passed #8610  •  git commit b9d054b7dc: E2E Tests for PR 910 "Update the meta description" from commit "b9d054b7dc78162d...
Project roar-dashboard-e2e
Branch Review enh/update-desc
Run status status check passed Passed #8610
Run duration 03m 58s
Commit git commit b9d054b7dc: E2E Tests for PR 910 "Update the meta description" from commit "b9d054b7dc78162d...
Committer Elijah Kelly
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 14
View all changes introduced in this branch ↗︎

Copy link
Collaborator

@ksmontville ksmontville left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add something about being a Stanford project?

Otherwise, looks good.

@richford richford merged commit 6b4d498 into main Oct 28, 2024
23 of 24 checks passed
@richford richford deleted the enh/update-desc branch October 28, 2024 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants