Fix tasks loading #883
Merged
Fix tasks loading #883
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit dea85ee): https://roar-staging--pr883-ref-318-query-compos-2dpomvjl.web.app (expires Mon, 21 Oct 2024 17:46:44 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e
|
||||||||||||||||||||||||
| Project |
roar-dashboard-e2e
|
| Run status |
|
| Run duration | 03m 51s |
| Commit |
|
| Committer | Maximilian Oertel |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
14
|
Emily-ejag
approved these changes
Oct 14, 2024
Base automatically changed from
ref/318/query-composables-merge
to
ref/318/query-composables
October 14, 2024 18:05
richford
approved these changes
Oct 14, 2024
richford
added a commit
that referenced
this pull request
Oct 15, 2024
* Introduce useOrgUsersQuery composable * Add unit tests for useOrgUsersQuery * Fix linter offenses * Introduce useTasksQuery composable * Extend withSetup test util to accept app options * Add unit tests * Introduce useAddTaskMutation * Improve task addition error handling * Improve view model handling * Introduce useUpdateTaskMutation and add mutation keys * Add mutation unit tests * Introduce useAddTaskVariantMutation and useUpdateTaskVariantMutation composables * Fix useTasksQuery and implement on Manage Variants page * Renamed task variants query * Fix ref val usage in useTaskVariantsQuery * Add unit tests for useTaskVariantsQuery * Introduce useTasksQuery and optimise conditional task loading * Extend useUserType for super admin handling * Apply super admin user type check changes to HomeSelector * Introduce useAdministrationsQuery composable * Remove obsolete user claims query * Fix administrations loading spinner * Introduce useUpdateUserMutation * Cleanup and remove obsolete logging * Add unit tests for useUpdateUserMutation * Add useUserDataQuery unit tests * Leverage useUserType for isSuperAdmin status * Add missing import * Regenerate package-lock due to npm/cli#4828 * Prepare for composable queries * Replace user claims query with useUserClaimsQuery * Use userType composable * Introduce useAdministrationsQuery composable and apply on administrator homepage * Fix loading state * Fix linter offenses * Restore itemsPerPage to original value * Restore package files * Upgrade tanstack and install dev tools * Remove comment * Remove incorrect parameters * Introduce useUserAssignments composable * Fix reactivity and minor issues * Introduce revised useAdministrationsQuery composable * Extend useTasksQuery to fetch by task IDs * Move useTasksQuery function to helper * Fix tasks query fetching and constants * Update useTasksQuery unit tests * Fix loading & query reactivity * Introduce useSurveyReponsesQuery composable * Add useSurveyResponsesQuery unit tests * Add useUserAssignmentsQuery unit tests * Fix reactivity in query composables * Remove duplications in favour of computeQueryOverrides helper * Fix vue warning * Improve computeQueryOverride reactivity and testability * Add unit tests for useUserStudentDataQuery * Overhaul useUserDataQuery unit tests * Add useUserClaimsQuery unit tests * Overhaul useUserClaimsQuery unit tests * Simplify useTaskVariantsQuery unit tests * Align useTasksQuery unit test names * Overhaul useSurveyResponsesQuery unit tests * Add useAdministrationsQuery unit tests * Add useDsgfOrgQuery unit tests * Add useLegalDocsQuery unit tests * Add computeQueryOverrides unit tests * Switch from uid to roarUid for survey response querying * Migrate score report queries to existing query composables * Introduce useAdministrationAssignmentsQuery composable * Add useDistrictsQuery unit tests * Split district query into separate composables * Introduce useSchoolQuery composable * Introduce useClassQuery composable * Introduce useGroupQuery composable * Fix doc comments * Introduce useFamilyQuery composable * Fix useAdministrationsQuery unit tests * Introduce new fetchDocumentsById query helper * Replace useClassQuery with useClassesQuery composable * Restructure district queries * Replace useSchoolQuery with useSchoolsQuery composable * Replace useGroupQuery with useGroupsQuery composable * Replace useFamilyQuery with useFamiliesQuery * Extend useDistrictsListQuery tests * Replace manual administration query with useAdministrationsQuery * Introduce new useAdministrationsStatsQuery composable * Migrate ProgressReport to individual org queries * Introduce reusable useOrgQuery composable for dynamic org querying * Migrate remaining page queries to composables * Switch to router based report routing * Add unit tests * Renamed page to match naming * Adapt useUserDataQuery to optionally fetch by manual user ID * Introduce useUserAdministrationAssignmentsQuery composable * Replace manual query with useAdministrationsQuery * Introduce tempoary useUsrRunPageQuery composable * Add useUserAdministrationAssignmentsQuery unit tests * Fix linter offenses * Fix comment typos * Make TanStack dev tools load conditionally * Fix administration assignments query * Remove staging conditional in favour of env var * Temporarily disable progress and report filtering tests * Replace administrations query with useAdministrationsQuery composable * Replace districts and schools queries with composables * Align query omposables and fix reactivity issues * Replace classes query with useClassesQuery composable * Fix linter offenses * Fix query state reactivity * Replace groups query with useGroupsQuery composable * Replace families query with useFamiliesQuery composable * Refactor CreateAdminitration page data handling * Fix query state handling * Remove console logs and obsolete comments * Refactor consent handling for administrators * Apply Consent Modal changes to remaining pages * Fix query reactivity * Fix document path destructuring * Add markdown/html sanitization * Add remaining consent types * Add loop breaker * Remove obsolete import * Add useSignOutMutation * Fix and improve signout mutation * Apply signOut mutation across pages * Remove query key indexes from queries * Combine ClassLink and Clever into single SSO landing page * Refactor store sso source * Add (intentional) typos * Fix home selector routing for sso flow * Introduce useTasksDictionaryQuery composable * Replace authStore tasks dictionary in favour of query composable * Remove obsolete import * Remove onUpdated hook for task dictionary refresh * Use AUTH_SSO_PROVIDERS instead of string literals * Clear query data before sign-out redirect * Fix vue-query hook usage error * Improve error handling and logging * Add inline initStateFromRedirect comments * Add unit tests * Introduce useDeleteAdministrationMutation mutation * Improve administration loader * Fix error handling in fetchByDocId * Update JSDoc * Update src/components/auth/RegisterStudent.vue Co-authored-by: Kyle Montville <[email protected]> * Update src/components/auth/RegisterStudent.vue Co-authored-by: Kyle Montville <[email protected]> * Improve error handling * Updated copy to match form option * Revert "Improve error handling" This reverts commit 4fa5c46. * Fix post-signout firekit initialisation * Fix linter offenses * Fix SWR task loading * Fix Vocab task loading * Fix SRE task loading * Fix Ran task loading * Fix PA task loading * Fix Multichoice task loading * Fix MEP task loading * Fix Levante task loading * Fix Letter task loading * Fix Fluency task loading * Fix Crowding task loading * Fix tasks loading (#883) * Fix SWR task loading * Fix Vocab task loading * Fix SRE task loading * Fix Ran task loading * Fix PA task loading * Fix Multichoice task loading * Fix MEP task loading * Fix Levante task loading * Fix Letter task loading * Fix Fluency task loading * Fix Crowding task loading * Fix administration selection * Fix administrations list rendering (#888) * Fix participant homepage loading state (#889) * Fix flashing loading states on participant homepage * Fix refs --------- Co-authored-by: Emily Arteaga <[email protected]> Co-authored-by: Kyle Montville <[email protected]> Co-authored-by: Adam Richie-Halford <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the identified issues regarding the loading of tasks within the dashboard.
Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Ref https://github.com/yeatmanlab/roar/issues/318