Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix post-logout Firekit initialisation #870

Merged

Conversation

maximilianoertel
Copy link
Collaborator

@maximilianoertel maximilianoertel commented Oct 11, 2024

Proposed changes

This PR fixes the post-logout Firekit initialisation currently preventing a user from signing-out and immediately signing-in again.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

n/a

Further comments

n/a

Resolves #865
Ref https://github.com/yeatmanlab/roar/issues/318

Copy link

github-actions bot commented Oct 11, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 5.1% 390 / 7646
🔵 Statements 4.99% 421 / 8431
🔵 Functions 6.12% 115 / 1878
🔵 Branches 2.4% 110 / 4570
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/App.vue 0% 0% 0% 0% 33, 33-36, 35, 35, 42-44, 46-47, 49-53, 50-52, 55, 55, 57, 59-85, 87-105, 88, 90-102, 94-97, 95-96, 98-101, 99-100, 104, 107-118, 108-109, 111-117, 112-117, 114-116, 115
src/composables/mutations/useSignOutMutation.js 0% 100% 0% 0% 13-47, 14-16, 18-46, 21, 25, 29-31, 34, 38, 41, 44
src/store/auth.js 6.66% 2.85% 5.12% 6.84% 34, 37, 40, 43, 46, 49, 52, 55, 55-56, 56-57, 59, 64, 67-73, 68-69, 72, 76-83, 77-82, 78-79, 81, 84-90, 85-89, 86, 88, 93, 96, 99-107, 100-106, 104-105, 110-115, 111-114, 113, 118-122, 119-121, 120, 125-127, 126, 130, 133-136, 135, 139-140, 143-146, 145, 149-150, 153-157, 155-156, 158-167, 159-166, 161-165, 162, 164, 170, 173-180, 174-176, 175, 178-179, 183, 188
Generated in workflow #677 for commit 68aa290 by the Vitest Coverage Report Action

@maximilianoertel maximilianoertel self-assigned this Oct 11, 2024
@maximilianoertel maximilianoertel added the bug Something isn't working label Oct 11, 2024
Copy link

cypress bot commented Oct 11, 2024

roar-dashboard-e2e    Run #8199

Run Properties:  status check passed Passed #8199  •  git commit 68aa2906e2: Component Tests for PR 870 "Fix post-logout Firekit initialisation " from commit...
Project roar-dashboard-e2e
Run status status check passed Passed #8199
Run duration 01m 57s
Commit git commit 68aa2906e2: Component Tests for PR 870 "Fix post-logout Firekit initialisation " from commit...
Committer Maximilian Oertel
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 17

Copy link

github-actions bot commented Oct 11, 2024

Visit the preview URL for this PR (updated for commit 68aa290):

https://roar-staging--pr870-ref-318-query-compos-24gg8k0s.web.app

(expires Fri, 18 Oct 2024 16:00:32 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

@maximilianoertel maximilianoertel merged commit 01a2e93 into ref/318/query-composables Oct 11, 2024
21 of 22 checks passed
@maximilianoertel maximilianoertel deleted the ref/318/query-composables-signin branch October 11, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants