-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix post-logout Firekit initialisation #870
Merged
maximilianoertel
merged 2 commits into
ref/318/query-composables
from
ref/318/query-composables-signin
Oct 11, 2024
Merged
Fix post-logout Firekit initialisation #870
maximilianoertel
merged 2 commits into
ref/318/query-composables
from
ref/318/query-composables-signin
Oct 11, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Coverage Report
File Coverage
|
roar-dashboard-e2e Run #8199
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #8199
|
Run duration | 01m 57s |
Commit |
68aa2906e2: Component Tests for PR 870 "Fix post-logout Firekit initialisation " from commit...
|
Committer | Maximilian Oertel |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
17
|
Visit the preview URL for this PR (updated for commit 68aa290): https://roar-staging--pr870-ref-318-query-compos-24gg8k0s.web.app (expires Fri, 18 Oct 2024 16:00:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
richford
approved these changes
Oct 11, 2024
Emily-ejag
approved these changes
Oct 11, 2024
maximilianoertel
merged commit Oct 11, 2024
01a2e93
into
ref/318/query-composables
21 of 22 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR fixes the post-logout Firekit initialisation currently preventing a user from signing-out and immediately signing-in again.
Types of changes
Checklist
Justification of missing checklist items
n/a
Further comments
n/a
Resolves #865
Ref https://github.com/yeatmanlab/roar/issues/318