-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Component Tests for RoarDataTable #856
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksmontville
force-pushed
the
score-report-filtering-tests
branch
from
October 7, 2024 21:29
52f3074
to
71da2a1
Compare
roar-dashboard-e2e Run #7902
Run Properties:
|
Project |
roar-dashboard-e2e
|
Run status |
Passed #7902
|
Run duration | 03m 32s |
Commit |
00db06d5df: E2E Tests for PR 856 "Component Tests for RoarDataTable" from commit "00db06d5df...
|
Committer | Kyle |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
32
|
Visit the preview URL for this PR (updated for commit 00db06d): https://roar-staging--pr856-score-report-filteri-6ev85wqy.web.app (expires Mon, 14 Oct 2024 21:47:01 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
Emily-ejag
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Amazing :)
richford
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
This PR introduces component tests for
RoarDataTable.vue
component. It creates randomized mock input data which is used to test the various filtering functions of the component.This PR also refactors the
filterbar
slot ofRoarDataTable.vue
into its own componentFilterBar.vue
. This component uses a new composable functionuseFilteredTableData.js
which handles the filtering logic.There are also some small changes to the Cypress directory structure.
Overall, this PR helps to simplify the
ScoreReports.vue
component and makes the filtering tests forRoarDataTable.vue
more resilient.MAJOR CHANGES:
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments