Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Letter Canada to the Dashboard #825

Merged
merged 4 commits into from
Sep 24, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Sep 20, 2024

Proposed changes

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@Emily-ejag Emily-ejag requested a review from a team as a code owner September 20, 2024 20:44
@Emily-ejag Emily-ejag self-assigned this Sep 20, 2024
Copy link

github-actions bot commented Sep 20, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.96% 73 / 7565
🔵 Statements 0.89% 74 / 8312
🔵 Functions 0.75% 14 / 1852
🔵 Branches 0.44% 20 / 4538
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/router/index.js 0% 0% 0% 0% 7, 7, 11, 11, 14-423, 18, 31, 37, 43, 50, 57, 64, 71, 78, 85, 92, 99, 106, 113, 120, 127, 134, 141, 148, 155, 162, 169, 176, 185, 192, 199, 207, 213-214, 219, 224, 232, 238, 253-256, 255, 258-260, 275-276, 283-284, 291, 297, 303, 309, 316, 322, 328, 334, 341, 348, 355, 362, 368, 370, 374, 380, 386, 395, 401, 408, 414, 420, 425-434, 429-430, 430-431, 431-432, 436-516, 437, 439-443, 440, 442, 445, 447-455, 457, 459-465, 460-465, 463-464, 467-474, 472-473, 477-478, 481-482, 490-506, 491-506, 497-503, 498-503, 501-502, 504-505, 509-512, 510-511, 514-515
Generated in workflow #434

Copy link

github-actions bot commented Sep 20, 2024

Visit the preview URL for this PR (updated for commit 0f75b93):

https://roar-staging--pr825-enh-adding-path-for-w27928o7.web.app

(expires Mon, 30 Sep 2024 22:50:54 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Sep 20, 2024

roar-dashboard-e2e    Run #7113

Run Properties:  status check passed Passed #7113  •  git commit 0f75b9397b: Component Tests for PR 825 "Adding Letter Canada to the Dashboard" from commit "...
Project roar-dashboard-e2e
Branch Review enh/adding-path-for-letter-canadian
Run status status check passed Passed #7113
Run duration 01m 26s
Commit git commit 0f75b9397b: Component Tests for PR 825 "Adding Letter Canada to the Dashboard" from commit "...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
View all changes introduced in this branch ↗︎

@richford
Copy link
Contributor

@Emily-ejag , can you fix some of the merge conflicts? I think a rebase after Kyle's PR ought to do it.

@Emily-ejag
Copy link
Contributor Author

@Emily-ejag , can you fix some of the merge conflicts? I think a rebase after Kyle's PR ought to do it.

Done!

@tonyamurray tonyamurray self-requested a review September 23, 2024 23:45
Copy link

@tonyamurray tonyamurray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested and it works.

@Emily-ejag Emily-ejag merged commit 2ad2d9d into main Sep 24, 2024
24 checks passed
@Emily-ejag Emily-ejag deleted the enh/adding-path-for-letter-canadian branch September 24, 2024 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants