Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CODEOWNERS file #808

Merged
merged 2 commits into from
Sep 17, 2024
Merged

Add CODEOWNERS file #808

merged 2 commits into from
Sep 17, 2024

Conversation

richford
Copy link
Contributor

Proposed changes

This PR adds a CODEOWNERS so that we can define who is allowed to approve PRs.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@richford richford requested a review from a team September 16, 2024 23:49
Copy link

github-actions bot commented Sep 16, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.96% 73 / 7564
🔵 Statements 0.89% 74 / 8311
🔵 Functions 0.75% 14 / 1849
🔵 Branches 0.44% 20 / 4538
File CoverageNo changed files found.
Generated in workflow #359

Copy link

github-actions bot commented Sep 16, 2024

Visit the preview URL for this PR (updated for commit 2529cda):

https://roar-staging--pr808-enh-codeowners-5wmdmje4.web.app

(expires Mon, 23 Sep 2024 23:53:02 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Sep 16, 2024

roar-dashboard-e2e    Run #6623

Run Properties:  status check passed Passed #6623  •  git commit 2529cdaebd: E2E Tests for PR 808 "Add CODEOWNERS file" from commit "2529cdaebd2d6f464ed21800...
Project roar-dashboard-e2e
Branch Review enh/codeowners
Run status status check passed Passed #6623
Run duration 04m 24s
Commit git commit 2529cdaebd: E2E Tests for PR 808 "Add CODEOWNERS file" from commit "2529cdaebd2d6f464ed21800...
Committer Adam Richie-Halford
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 1
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

@richford richford merged commit 0de8c15 into main Sep 17, 2024
5 of 18 checks passed
@richford richford deleted the enh/codeowners branch September 17, 2024 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants