-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix test Open Admins #779
Merged
Merged
Fix test Open Admins #779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage Report
File CoverageNo changed files found. |
Visit the preview URL for this PR (updated for commit be2d1f0): https://roar-staging--pr779-fix-roam-test-all-op-5itic4aq.web.app (expires Thu, 12 Sep 2024 16:08:30 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
roar-dashboard-e2e Run #5711
Run Properties:
|
Project |
roar-dashboard-e2e
|
Branch Review |
fix/roam-test-all-open-admins
|
Run status |
Passed #5711
|
Run duration | 02m 19s |
Commit |
be2d1f03e2: Tests for PR 779 "WIP: Fix test Open Admins" from commit "be2d1f03e24dc39ad6f302...
|
Committer | emily-ejag |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
32
|
View all changes introduced in this branch ↗︎ |
richford
approved these changes
Sep 5, 2024
lucasxsong
approved these changes
Sep 5, 2024
ksmontville
approved these changes
Sep 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
The page refreshes when It picks the administration again after a refresh. So the solution we got with @ksmontville is to go back to switching to optional assignments.
Also reduced at least 1 min of sre and sre-es, since the game goes by time, we don't need to run the loop 80 times, I reduced it to 50. (33 is the max I have seen it uses {left-arrow} {write-arrow}, but kept it on 50 just in case)
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
We need this for deployment
Further comments