Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test Open Admins #779

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix test Open Admins #779

merged 1 commit into from
Sep 5, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Sep 5, 2024

Proposed changes

The page refreshes when It picks the administration again after a refresh. So the solution we got with @ksmontville is to go back to switching to optional assignments.

Also reduced at least 1 min of sre and sre-es, since the game goes by time, we don't need to run the loop 80 times, I reduced it to 50. (33 is the max I have seen it uses {left-arrow} {write-arrow}, but kept it on 50 just in case)

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

We need this for deployment

Further comments

Copy link

github-actions bot commented Sep 5, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.94% 73 / 7685
🔵 Statements 0.9% 74 / 8181
🔵 Functions 0.68% 14 / 2040
🔵 Branches 0.46% 20 / 4297
File CoverageNo changed files found.
Generated in workflow #190

Copy link

github-actions bot commented Sep 5, 2024

Visit the preview URL for this PR (updated for commit be2d1f0):

https://roar-staging--pr779-fix-roam-test-all-op-5itic4aq.web.app

(expires Thu, 12 Sep 2024 16:08:30 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Sep 5, 2024

roar-dashboard-e2e    Run #5711

Run Properties:  status check passed Passed #5711  •  git commit be2d1f03e2: Tests for PR 779 "WIP: Fix test Open Admins" from commit "be2d1f03e24dc39ad6f302...
Project roar-dashboard-e2e
Branch Review fix/roam-test-all-open-admins
Run status status check passed Passed #5711
Run duration 02m 19s
Commit git commit be2d1f03e2: Tests for PR 779 "WIP: Fix test Open Admins" from commit "be2d1f03e24dc39ad6f302...
Committer emily-ejag
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 32
View all changes introduced in this branch ↗︎

@Emily-ejag Emily-ejag self-assigned this Sep 5, 2024
@Emily-ejag Emily-ejag added the bug Something isn't working label Sep 5, 2024
@Emily-ejag Emily-ejag changed the title WIP: Fix test Open Admins Fix test Open Admins Sep 5, 2024
@Emily-ejag Emily-ejag merged commit caee114 into main Sep 5, 2024
18 checks passed
@Emily-ejag Emily-ejag deleted the fix/roam-test-all-open-admins branch September 5, 2024 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants