Restore default sort

[kellyel]

Proposed changes

Update the format of the default sort to make it functional on score and progress reports.

Types of changes

What types of changes does this pull request introduce?

• Bugfix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to not work as expected)
• Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
• Documentation Update
• Tests (new or updated tests)
• Style (changes to code styling)
• CI (continuous integration changes)
• Repository Maintenance
• Other (please describe below)

Checklist

• I have read the guidelines for contributing.
• The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
• Linting checks pass with my changes.
• Any existing unit tests pass with my changes.
• Any existing end-to-end tests pass with my changes.
• I have added tests that prove my fix is effective or that my feature works.
• If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
• I have added JSDoc comments as appropriate.
• I have added the necessary documentation to the roar-docs repository.
• I have shared this PR on the roar-pr-reviews channel (if I have access)
• I have linked relevant issues (if any)

Justification of missing checklist items

Testing Steps

• Navigate to score report
• After table loads, there should already be a sort applied - school (1), grade (2), and last name (3)
• Navigate to a progress report
• Should see the same default sort without any manual intervention.

Further comments

Interface defined here: https://v3.primevue.org/datatable/#pre_sort

[github-actions]

Coverage Report

Status	Category	Percentage	Covered / Total
🔵	Lines	0.95%	73 / 7645
🔵	Statements	0.9%	74 / 8140
🔵	Functions	0.68%	14 / 2032
🔵	Branches	0.46%	20 / 4277

File Coverage

File	Stmts	% Branch	% Funcs	% Lines	Uncovered Lines
Changed Files
src/components/RoarDataTable.vue	0%	0%	0%	0%	686, 597-602, 600-601, 604, 621-622, 624-628, 625-627, 626, 626, 629-630, 632-648, 650-669, 653-667, 655-664, 666, 668, 671-673, 672, 675, 677-683, 678-681, 679-680, 682, 685, 689-695, 690-691, 693-694, 696, 700-709, 711-743, 712-741, 716-718, 717, 720-722, 725-727, 726, 730-733, 731-732, 735-740, 736-739, 742, 745-746, 748-751, 749-750, 753-767, 754-764, 766, 771-777, 774-776, 775, 778, 781-794, 796-809, 811-816, 818-829, 831-840, 842-873, 858-871, 867-870, 869, 872, 875-880, 878-879, 879, 882-887, 885-886, 886, 889-894, 892-893, 893, 896-900, 898-899, 899, 902-906, 904-905, 905, 908-912, 910-911, 911, 915-917, 916-917, 920-922, 921, 921, 924, 924-931, 926, 926-930, 928-929, 933-934, 936-939, 937-938, 941, 6, 8, 20, 22, 34, 36, 66-67, 119-121, 123, 137-139, 141, 155-157, 159, 173, 175, 179, 193, 195, 197, 211, 213, 215, 290, 303, 309, 320, 330, 341, 382, 401, 411, 421, 431, 441, 543-545, 55, 62, 75-76, 122, 140, 158, 178, 196, 214, 261, 269, 276, 284, 289, 294, 348, 522
src/pages/ProgressReport.vue	0%	0%	0%	0%	177, 179, 181, 196, 198-202, 204-209, 205-207, 206, 208, 211-213, 212, 215-224, 226-231, 227-230, 233-235, 238-244, 240, 245, 245-246, 246-247, 247, 249-256, 252, 258-267, 260, 265, 269-275, 271, 278-284, 280, 286, 286, 292-298, 294, 300-309, 301-308, 302-305, 303-304, 307, 311-384, 312, 312, 314, 316-381, 318, 320-324, 323, 325-337, 339-379, 342-343, 345-373, 346-373, 353-373, 360-365, 367-372, 374, 377, 380, 383, 386-389, 387-388, 391-413, 392-410, 393-402, 401, 403-405, 404, 406-408, 407, 409, 411-412, 415-442, 416-434, 417-426, 425, 427-429, 428, 430-432, 431, 433, 435-441, 444-533, 445, 445, 447-457, 448-456, 458-467, 458-466, 468-470, 468-469, 471-473, 471-472, 475, 477-490, 478-481, 479-480, 482-489, 492-494, 493, 496, 496-503, 498-502, 499, 501, 505-506, 508-512, 509-511, 510, 514-518, 515-517, 516, 520-531, 521-530, 532, 535, 537-540, 539, 542-560, 543-559, 545-550, 547-549, 548, 551-555, 552-554, 553, 556, 558, 563-570, 565-566, 566, 568-569, 572-574, 573, 573, 576-578, 577, 577, 2-4, 6, 8-9, 14-15, 21-22, 38, 45-46, 69-73, 123, 135, 138-139, 151, 24, 126, 142
src/pages/ScoreReport.vue	0%	0%	0%	0%	369, 327, 329, 331, 346, 348-353, 349-351, 350, 352, 355-359, 361-363, 362, 365, 367, 370, 370, 372-421, 373-375, 378-381, 380, 384, 386-405, 387-388, 388, 391-392, 394-397, 396, 399-401, 400, 402-404, 403, 408-411, 410, 412-418, 420, 423-432, 434-439, 435-438, 440-442, 445-451, 447, 452, 452-453, 453-454, 454, 456-462, 458, 464-470, 466, 473-479, 475, 481-490, 482-489, 483-486, 484-485, 488, 492-501, 493-500, 494-497, 495-496, 499, 503, 503, 510-516, 512, 520-551, 521-550, 522-550, 524-550, 526-550, 528-550, 533-539, 538, 540-550, 542-547, 544, 546, 548-550, 549, 552, 555-599, 567-570, 572-586, 577-583, 578-579, 581-582, 585, 588, 588-589, 589, 591-598, 604-826, 605-825, 606, 609, 611, 613-815, 615, 617-621, 620, 623, 625-645, 647-808, 651-658, 655, 657, 659-663, 660, 662, 665-672, 666-672, 669, 671, 674-676, 675, 679, 682-691, 693-699, 694-699, 696-699, 698, 701, 704-715, 717-751, 718-751, 727-728, 730-751, 739, 741-750, 752-770, 753-763, 761, 764, 766-769, 771-784, 772-776, 776-777, 777-778, 778-783, 787-801, 803-807, 804, 806, 811-812, 814, 818, 818, 820-822, 821, 824, 828, 831, 833-836, 835, 838-864, 840-842, 841, 843-863, 844, 846, 848-852, 849-851, 850, 853-857, 854-856, 855, 858, 860, 862, 866-872, 867, 869-871, 873, 875-880, 882-952, 883-944, 884-892, 891, 893-895, 894, 896-942, 897-918, 899-918, 903-918, 908-918, 911, 913-914, 916-917, 919-941, 920-938, 922-935, 923-925, 924, 926-931, 927, 929, 929-930, 933, 933-934, 937, 940, 943, 945-951, 954-1026, 955-1018, 956-965, 964, 966-968, 967, 969-1016, 970-991, 972-991, 976-991, 981-991, 984, 986-987, 989-990, 993-1015, 994-1012, 996-1009, 997-999, 998, 1000-1005, 1001, 1003, 1003-1004, 1007, 1007-1008, 1011, 1014, 1017, 1019-1025, 1029-1030, 1033, 1035-1073, 1036-1042, 1044-1050, 1046-1049, 1047-1048, 1052, 1052, 1054-1055, 1057-1058, 1058, 1060-1071, 1061-1071, 1068-1071, 1070, 1072, 1077-1257, 1078, 1078-1103, 1093-1102, 1104-1113, 1104-1112, 1114-1127, 1114-1126, 1116-1123, 1125, 1128-1130, 1128-1129, 1132, 1134-1142, 1135-1141, 1144-1146, 1145, 1148-1154, 1149-1153, 1150, 1152, 1156-1162, 1165-1171, 1166-1170, 1167-1169, 1168, 1174-1179, 1182-1186, 1183-1185, 1184, 1188-1255, 1190, 1193-1221, 1194-1221, 1201-1221, 1208, 1210-1220, 1211-1220, 1213-1220, 1215-1220, 1217, 1219, 1223, 1225-1235, 1232, 1234, 1237-1254, 1249-1251, 1250, 1252, 1256, 1259-1263, 1260-1262, 1261, 1261-1262, 1265-1276, 1266-1267, 1267-1268, 1268, 1270-1272, 1271, 1274-1275, 1278-1282, 1279-1281, 1280, 1285-1291, 1286-1287, 1287, 1289-1290, 1293-1295, 1294, 1294, 1297-1302, 1298-1301, 1301, 2-3, 5, 8, 11-12, 14-15, 20-21, 26, 28, 55, 58-59, 61, 70-71, 74, 88-89, 95, 101, 108, 116, 135, 137, 149, 152-153, 165, 171, 184, 190, 196, 202, 218, 269-270, 30, 140, 156, 174

Generated in workflow #153

[github-actions]

Visit the preview URL for this PR (updated for commit 0f7bc96):

https://roar-staging--pr774-fix-score-sort-njbpfp1h.web.app

_{(expires Tue, 10 Sep 2024 21:56:36 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460}

ROAR

[cypress]

roar-dashboard-e2e    Run #5656

Run Properties:   Passed #5656  •  0f7bc96ae3: Tests for PR 774 "Restore default sort" from commit "0f7bc96ae3bcc1b00934332c4d3...

Project	roar-dashboard-e2e
Branch Review	fix/score-sort
Run status	Passed #5656
Run duration	07m 24s
Commit	0f7bc96ae3: Tests for PR 774 "Restore default sort" from commit "0f7bc96ae3bcc1b00934332c4d3...
Committer	Elijah Kelly
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	26
View all changes introduced in this branch ↗︎

[Emily-ejag]

The only issue I see is that K grade is being placed as bigger, because it is a letter --> Is there a way to associate K with 0?

[kellyel]

The only issue I see is that K grade is being placed as bigger, because it is a letter --> Is there a way to associate K with 0?

This is an existing issue we know we want to address. It may be outside of the scope of this PR, as PrimeVue doesn't support custom sort functions for the table as far as I can find, which leaves hacking a solution. I've just tried one solution, and it seems to be ineffective. This leads me to believe that this solution might need more thought with a separate PR.

[Emily-ejag]

The only issue I see is that K grade is being placed as bigger, because it is a letter --> Is there a way to associate K with 0?

This is an existing issue we know we want to address. It may be outside of the scope of this PR, as PrimeVue doesn't support custom sort functions for the table as far as I can find, which leaves hacking a solution. I've just tried one solution, and it seems to be ineffective. This leads me to believe that this solution might need more thought with a separate PR.

Thanks for clarifying @kellyel :)