Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store State of Show Optional Assessments #773

Merged
merged 2 commits into from
Sep 3, 2024

Conversation

ksmontville
Copy link
Collaborator

@ksmontville ksmontville commented Sep 3, 2024

Proposed changes

This PR stores the state of "show optional assessments" within the auth store. This allows users to persist this state between assessments.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

@ksmontville ksmontville self-assigned this Sep 3, 2024
@ksmontville ksmontville added impact: low This is a nice feature to have but low impact on the overall project design-alignment labels Sep 3, 2024
Copy link

github-actions bot commented Sep 3, 2024

Coverage Report

Status Category Percentage Covered / Total
🔵 Lines 0.95% 73 / 7644
🔵 Statements 0.9% 74 / 8139
🔵 Functions 0.68% 14 / 2032
🔵 Branches 0.46% 20 / 4277
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
src/pages/HomeParticipant.vue 0% 0% 0% 0% 108-112, 114, 116-120, 118, 118-119, 122, 124, 133, 135-137, 136, 136, 139-141, 140, 140, 143-144, 150-156, 152, 162-170, 164, 172, 172, 172-173, 173, 179-194, 182-190, 184-188, 196-198, 197, 197, 201-206, 208-216, 210-214, 211-213, 215, 218-220, 222-225, 227, 229-231, 233-271, 234-237, 239-255, 240-241, 243-251, 244-250, 246-250, 248-249, 252-254, 253, 258-266, 259-266, 261-265, 262-264, 267-271, 268-270, 275-287, 281-284, 282-283, 286, 290, 290, 290, 296-310, 299-305, 300-303, 312-318, 314, 320-322, 321, 324-326, 325, 328-331, 329, 329-330, 333-336, 334-335, 340-382, 341-380, 342-366, 345-347, 352, 352-363, 368-377, 370-376, 371-375, 372-374, 373, 379, 381, 384-386, 385, 385, 388-390, 389, 389, 393-402, 394-401, 397, 405-407, 406, 410-412, 411, 411, 415-422, 416-418, 417, 419-421, 424-440, 427-429, 428, 430-431, 431, 434-437, 436, 12, 30-31, 50, 55, 70, 72, 18, 33-34, 43
src/store/auth.js 0% 0% 0% 0% 9-241, 10-240, 14-35, 39, 42, 45, 48, 51, 54, 57, 60, 60-61, 61-62, 64, 68-69, 72-79, 73-78, 74-75, 77, 80-87, 81-86, 82-83, 85, 90-92, 91, 95, 98-102, 99-101, 103, 106, 109, 112-120, 113-119, 117-118, 123-128, 124-127, 126, 131-135, 132-134, 133, 138-140, 139, 143-146, 145, 149-152, 151, 155, 158-159, 162-163, 166-170, 168-169, 171-180, 172-179, 174-178, 175, 177, 183, 186-188, 191-214, 192-211, 193-202, 204-207, 209-210, 213, 217-224, 218-220, 219, 222-223, 227, 232, 243-245, 244
Generated in workflow #156

Copy link

github-actions bot commented Sep 3, 2024

Visit the preview URL for this PR (updated for commit e8a5654):

https://roar-staging--pr773-store-optional-asses-oem4ytqu.web.app

(expires Tue, 10 Sep 2024 22:13:00 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Sep 3, 2024

roar-dashboard-e2e    Run #5591

Run Properties:  status check passed Passed #5591  •  git commit e8a5654ba8: Tests for PR 773 "Store State of Show Optional Assessments" from commit "e8a5654...
Project roar-dashboard-e2e
Branch Review store-optional-assessment-state
Run status status check passed Passed #5591
Run duration 04m 33s
Commit git commit e8a5654ba8: Tests for PR 773 "Store State of Show Optional Assessments" from commit "e8a5654...
Committer Kyle
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 26
View all changes introduced in this branch ↗︎

@ksmontville ksmontville merged commit cb13feb into main Sep 3, 2024
18 checks passed
@ksmontville ksmontville deleted the store-optional-assessment-state branch September 3, 2024 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design-alignment impact: low This is a nice feature to have but low impact on the overall project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants