-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cypress Component Testing Framework #767
Conversation
roar-dashboard-e2e Run #5766
Run Properties:
|
Project |
roar-dashboard-e2e
|
Branch Review |
component-testing
|
Run status |
Passed #5766
|
Run duration | 01m 42s |
Commit |
e85a5919f5: Component Tests for PR 767 "Add Cypress Component Testing Framework" from commit...
|
Committer | Kyle |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
2
|
View all changes introduced in this branch ↗︎ |
Visit the preview URL for this PR (updated for commit e85a591): https://roar-staging--pr767-component-testing-40llsf40.web.app (expires Thu, 12 Sep 2024 20:38:29 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
d6af285
to
cdfea4e
Compare
cdfea4e
to
794c844
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great and exciting to get the first component tests on the project! Just a couple of minor-ish questions below from me:
Co-authored-by: Maximilian Oertel <[email protected]>
Co-authored-by: Maximilian Oertel <[email protected]>
Co-authored-by: Maximilian Oertel <[email protected]>
999bdb1
to
707f728
Compare
…es, change styles.js to styles.css
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
Proposed changes
This PR introduces Cypress component testing to the ROAR dashboard.
This initial effort sets up the ability to mount components in isolation and begin testing them within the Cypress testing suite.
WAITING ON:
#771MAJOR CHANGES:
Primevue
version to 3.43.0component.js
Cypress support file which sets up the Vue app context for each component that is mounted in testingsetup.js
andplugins.js
; this change in app instance setup was necessary in order for the Cypress tests to accurately mock the context of our production Vue app.HOW TO TEST:
npm run dev
npm run:cypress open
NavBar.cy.js
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments