-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move core assessments and visually separate tasks in score report #656
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 0363f93): https://roar-staging--pr656-enh-separate-core-ta-s4xsw8tc.web.app (expires Wed, 19 Jun 2024 23:10:09 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
1 flaky test on run #2622 ↗︎
Details:
cypress/e2e/partner-admin/default-tests/testProgressReportFiltering.spec.cy.js • 1 flaky testReview all test suite changes for PR #656 ↗︎ |
ksmontville
approved these changes
Jun 12, 2024
Co-authored-by: Kyle Montville <[email protected]>
Co-authored-by: Kyle Montville <[email protected]>
Co-authored-by: Kyle Montville <[email protected]>
Emily-ejag
commented
Jun 12, 2024
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
On the Score Report move "Word, Sentence, and Phoneme" first, then gray out cell that belong to the other task because those are not validated.
On Progress Report only move the validated tasks first.
Types of changes
What types of changes does this pull request introduce?
Checklist
Justification of missing checklist items
Further comments