Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move core assessments and visually separate tasks in score report #656

Merged
merged 7 commits into from
Jun 12, 2024

Conversation

Emily-ejag
Copy link
Contributor

@Emily-ejag Emily-ejag commented Jun 12, 2024

Proposed changes

On the Score Report move "Word, Sentence, and Phoneme" first, then gray out cell that belong to the other task because those are not validated.

On Progress Report only move the validated tasks first.

Types of changes

What types of changes does this pull request introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactoring (non-breaking change that does not add functionality but makes code cleaner or more efficient)
  • Documentation Update
  • Tests (new or updated tests)
  • Style (changes to code styling)
  • CI (continuous integration changes)
  • Repository Maintenance
  • Other (please describe below)

Checklist

  • I have read the guidelines for contributing.
  • The changes in this PR are as small as they can be. They represent one and only one fix or enhancement.
  • Linting checks pass with my changes.
  • Any existing unit tests pass with my changes.
  • Any existing end-to-end tests pass with my changes.
  • I have added tests that prove my fix is effective or that my feature works.
  • If this PR fixes an existing issue, I have added a unit or end-to-end test that will detect if this issue reoccurs.
  • I have added JSDoc comments as appropriate.
  • I have added the necessary documentation to the roar-docs repository.
  • I have shared this PR on the roar-pr-reviews channel (if I have access)
  • I have linked relevant issues (if any)

Justification of missing checklist items

Further comments

Copy link

github-actions bot commented Jun 12, 2024

Visit the preview URL for this PR (updated for commit 0363f93):

https://roar-staging--pr656-enh-separate-core-ta-s4xsw8tc.web.app

(expires Wed, 19 Jun 2024 23:10:09 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Jun 12, 2024

1 flaky test on run #2622 ↗︎

0 26 0 0 Flakiness 1

Details:

Tests for PR 656 "Move core assessments and visually separate tasks in score rep...
Project: roar-dashboard-e2e Commit: 0363f93d47
Status: Passed Duration: 03:41 💡
Started: Jun 12, 2024 11:09 PM Ended: Jun 12, 2024 11:13 PM
Flakiness  cypress/e2e/partner-admin/default-tests/testProgressReportFiltering.spec.cy.js • 1 flaky test

View Output

Test Artifacts
The partner admin can view progress reports for a given administration and a not applicable filter returns an empty message > Selects an administration, views its score report, then accesses the column filter to filter by a non-returnable filter Test Replay Screenshots

Review all test suite changes for PR #656 ↗︎

src/pages/ScoreReport.vue Outdated Show resolved Hide resolved
src/pages/ScoreReport.vue Show resolved Hide resolved
src/pages/ScoreReport.vue Outdated Show resolved Hide resolved
src/pages/ScoreReport.vue Show resolved Hide resolved
Emily-ejag and others added 3 commits June 12, 2024 15:42
src/pages/ScoreReport.vue Outdated Show resolved Hide resolved
@Emily-ejag Emily-ejag merged commit 099f29c into main Jun 12, 2024
15 of 16 checks passed
@Emily-ejag Emily-ejag deleted the enh/separate-core-tasks branch June 12, 2024 23:13
Copy link

sentry-io bot commented Jun 20, 2024

Suspect Issues

This pull request was deployed and Sentry observed the following issues:

  • ‼️ TypeError: Cannot read properties of undefined (reading 'includes') progressReportColumns(src/pages/ProgressReport) View Issue

Did you find this useful? React with a 👍 or 👎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants