-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add PR template #628
ENH: Add PR template #628
Conversation
Visit the preview URL for this PR (updated for commit 9208b89): https://roar-staging--pr628-enh-add-pr-template-mtnr9rvr.web.app (expires Thu, 06 Jun 2024 21:11:32 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
I think we should add a section for images if applicable. |
Passing run #2210 ↗︎
Details:
Review all test suite changes for PR #628 ↗︎ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General approval, and happy to have this. Think the template will give PR reviewing a lot of useful context and provide good documentation on new additions as well. Just had two small comments. Thanks for writing this up!
Resolved in latest commit by adding a suggestion for images in the HTML comment for the first section. |
Proposed changes
This PR adds a PR template that will serve as a starting point for all future PRs. It is intended to be a general purpose PR template for use in ALL ROAR repositories. If it is approved and merged for this repository, I will then add it to all other ROAR repos.
Types of changes
What types of changes does your code introduce?
Put an
x
in the boxes that applyChecklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.Justification of missing checklist items
This PR does not warrant adding any tests.