Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update firestore rules to check super_admin status from firestore #465

Merged
merged 1 commit into from
Apr 1, 2024

Conversation

richford
Copy link
Contributor

rather than custom auth claims

@richford richford marked this pull request as ready for review March 28, 2024 22:11
Copy link

github-actions bot commented Mar 28, 2024

Visit the preview URL for this PR (updated for commit ca6d8e4):

https://roar-staging--pr465-enh-super-admin-from-3m2swhr3.web.app

(expires Thu, 04 Apr 2024 22:15:29 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460

Copy link

cypress bot commented Mar 28, 2024

Passing run #861 ↗︎

0 34 0 0 Flakiness 0

Details:

Tests for PR 465 "Update firestore rules to check super_admin status from firest...
Project: roar-dashboard-e2e Commit: ca6d8e43fd
Status: Passed Duration: 43:24 💡
Started: Mar 28, 2024 10:18 PM Ended: Mar 28, 2024 11:01 PM

Review all test suite changes for PR #465 ↗︎

Copy link
Collaborator

@lucasxsong lucasxsong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@richford richford merged commit 8179126 into main Apr 1, 2024
13 of 14 checks passed
@richford richford deleted the enh/super-admin-from-firestore branch April 1, 2024 21:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants