Implement spanish consent modal #457
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 5a35dab): https://roar-staging--pr457-enh-spanish-assent-c4kxr89n.web.app (expires Tue, 02 Apr 2024 21:59:28 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: 2631e9c58fd0104ecbfddd72a62245ddac467460 |
richford
requested changes
Mar 26, 2024
src/pages/HomeSelector.vue
Outdated
| @@ -82,7 +82,7 @@ const isAdmin = computed(() => { | |||
| return true; | |||
| }); | |||
|
|
|||
| const consentType = computed(() => (isAdmin.value ? 'tos' : 'assent')); | |||
| const consentType = computed(() => (isAdmin.value ? 'tos' : i18n.locale.value === 'es' ? 'assent-es' : 'assent')); | |||
There was a problem hiding this comment.
Requested change:
- to avoid a nested ternary
- to allow Spanish localizations (otherwise
es-coresults in the English assent form)
Suggested change
| const consentType = computed(() => (isAdmin.value ? 'tos' : i18n.locale.value === 'es' ? 'assent-es' : 'assent')); | |
| const consentType = computed(() => { | |
| if (isAdmin.value) { | |
| return 'tos'; | |
| } else { | |
| return i18n.locale.value.includes('es') ? 'assent-es' : 'assent' | |
| } | |
| }); |
richford
approved these changes
Mar 26, 2024
Emily-ejag
approved these changes
Mar 26, 2024
1 flaky test on run #815 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Testing play through of vocab, cva, letter, and multichoice games as a participant > ROAR - Picture Vocabulary Play through Test |
Test Replay
Screenshots
|
|
Review all test suite changes for PR #457 ↗︎
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.